Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
|
Could you verify that the Unicode name changes are not in practice changing things? It doesn't look like it in my browser but I don't have time to investigate in detail. If you want to just drop those changes that's fine with me too. Otherwise r=me; @bors rollup=always |
Mark-Simulacrum
added
S-waiting-on-author
|
@XAMPPRocky can you update this? |
Contributor
Author
|
I'm just going to open a new PR since it's easier. |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 2, 2020
Update my mailmap entry superceding rust-lang#68891
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 3, 2020
Update my mailmap entry superceding rust-lang#68891
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Mar 3, 2020
Update my mailmap entry superceding rust-lang#68891
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was made using GitHub's UI and it seems that some the unicode for two other people's name was also changed.