Remove qualify_min_const_fn pass#68940
Closed
ecstatic-morse wants to merge 5 commits intorust-lang:masterfrom
Closed
Remove qualify_min_const_fn pass#68940ecstatic-morse wants to merge 5 commits intorust-lang:masterfrom
qualify_min_const_fn pass#68940ecstatic-morse wants to merge 5 commits intorust-lang:masterfrom
Conversation
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
There's also some additional errors being reported in some UI tests that are unrelated to const-eval. I'll need to figure out what's going on here. |
Collaborator
|
☔ The latest upstream changes (presumably #68929) made this pull request unmergeable. Please resolve the merge conflicts. |
JohnCSimon
added
S-waiting-on-author
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 15, 2020
…-gate, r=oli-obk Return feature gate as a `Symbol` A minor refactoring that will be needed for rust-lang#68940. That PR is blocked on me changing the error comments in a whole lot of UI tests. r? @oli-obk
|
@ecstatic-morse any updates? |
Dylan-DPC-zz
added
S-waiting-on-author
joelpalmer
added
S-waiting-on-author
Contributor
|
r? @oli-obk totally forgot this exists |
Contributor
|
let's wait for |
oli-obk
reviewed
Jun 6, 2020
Contributor
Author
|
Closing this, but I think I'll get back to it in the near future. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having two MIR const-checking passes is confusing. This PR unifies
qualify_min_const_fnandcheck_consts.All checks from
qualify_min_const_fnthat were not already implemented incheck_constshave been assigned a structured error. Unfortunately, this will require a lot of changes to expected test output. This is becausequalify_min_const_fnbailed out after the first error was found, whilecheck_constsreports all errors in the function.cc @rust-lang/wg-const-eval