[DO NOT MERGE] Try setting __rust_probestack visibility back to hidden#69045
Closed
tmandry wants to merge 2 commits intorust-lang:masterfrom
Closed
[DO NOT MERGE] Try setting __rust_probestack visibility back to hidden#69045tmandry wants to merge 2 commits intorust-lang:masterfrom
tmandry wants to merge 2 commits intorust-lang:masterfrom
Conversation
This is to fix rust-lang#68794, but it may break some platforms.
Member
Author
|
@bors try |
Collaborator
Member
|
Try by default is just Linux, which seems unlikely to break (presumably you tested on it already). You can enable other builders - though please avoid more than 4 at a time total - by copying from src/ci/azure-pipelines/auto.yml to try.yml. |
Collaborator
|
☀️ Try build successful - checks-azure |
Member
Author
|
@bors try |
Collaborator
|
⌛ Trying commit ddf7cb8 with merge 36d06a87830e7f655716dc7d2470ce1d12ebc263... |
Collaborator
|
☀️ Try build successful - checks-azure |
This was referenced Feb 12, 2020
Member
Author
|
Tests were successful, closing this in favor of the "real" change, #69086. |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 12, 2020
…n-DPC Update compiler-builtins to 0.1.25 - rust-lang/compiler-builtins#340 Set probestack visibility to hidden on ELF targets Fixes rust-lang#68794. Tested in CI: rust-lang#69045. r? @Mark-Simulacrum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix #68794, but it may break some platforms. Uploading this change to test in CI.
r? @ghost