Merged
Conversation
This re-exports the primitive types from libcore at `core::primitive` to allow macro authors to have a reliable location to use them from.
Take advantage of the fact that `check_mod_attrs` marks attributes as used and change their type to normal, so that any remaining uses will be warned about by the unused attribute lint.
…olnay Add primitive module to libcore This re-exports the primitive types from libcore at `core::primitive` to allow macro authors to have a reliable location to use them from. Fixes rust-lang#44865
…crum Deduplicate identifier printing a bit rust-lang#67010 introduced a couple more subtly different ways to print an identifier. This PR attempts to restore the order. The most basic identifier printing interface is `Formatter`-based now, so `String`s are not allocated unless required. r? @Mark-Simulacrum
Mark attributes consumed by `check_mod_attrs` as normal Take advantage of the fact that `check_mod_attrs` marks attributes as used and change their type to normal, so that any remaining uses will be warned about by the unused attribute lint.
syntax: Remove `Nt(Impl,Trait,Foreign)Item` Follow-up to rust-lang#69366. r? @Centril
remove redundant clones and import
…, r=Dylan-DPC Clean up e0370 e0371 r? @Dylan-DPC
…=Mark-Simulacrum [master] Backport release notes of 1.41.1 r? @Mark-Simulacrum
Author
|
@bors r+ rollup=never p=7 |
Collaborator
|
📌 Commit 8381862 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-azure |
This was referenced Feb 26, 2020
Contributor
|
This rollup caused a large regression for incremental builds of
Could either of those be the cause? Whichever PR is the cause should be backed out. |
Contributor
|
@nnethercote Changes from #69412 are most likely the cause. They introduced a functional regression, which has significant performance impact as well. Revert is in #69513. Thanks for catching this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
check_mod_attrsas normal #69412 (Mark attributes consumed bycheck_mod_attrsas normal)Nt(Impl,Trait,Foreign)Item#69423 (syntax: RemoveNt(Impl,Trait,Foreign)Item)Failed merges:
r? @ghost