Merged
Conversation
The hash tests were written before the assert_ne macro was added to the standard library. The assert_ne macro provides better output in case of a failure.
The current check for wether a target is no_std or not is matching for the string "-none-" in a target triple. This doesn't work for triples that end in "-none", like "aarch64-unknown-none". Fix this by matching for "-none" instead. I checked for all the current target triples containing "none", and this should not generate any false positives. This fixes an issue encountered in rust-lang#68334
docs: add mention of async blocks in move keyword docs Fixes rust-lang#69298
…LukasKalbertodt Use assert_ne in hash tests The hash tests were written before the assert_ne macro was added to the standard library. The assert_ne macro provides better output in case of a failure.
…wco,nagisa use to_vec() instead of .iter().cloned().collect() to convert slices to vecs.
…acrum use is_empty() instead of len() == x to determine if structs are empty.
…ark-Simulacrum Fix no_std detection for target triples The current check for wether a target is no_std or not is matching for the string `-none-` in a target triple. This doesn't work for triples that end in `-none`, like `aarch64-unknown-none`. Fix this by matching for `-none` instead. I checked for all the current target triples containing `none`, and this should not generate any false positives. This fixes an issue encountered in rust-lang#68334
use .to_string() instead of format!() macro to create strings handles what is left after rust-lang#69541
Author
|
@bors r+ rollup=never p=6 |
Collaborator
|
📌 Commit bbfec7c has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit bbfec7c with merge 3118685573a2f674f5b64d431a0f2a06ec20b1e1... |
Contributor
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Collaborator
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
Member
|
It seems spurious. |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-azure |
Contributor
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Feb 29, 2020
Tested on commit rust-lang/rust@3f9bddc. Direct link to PR: <rust-lang/rust#69570> 💔 rls on linux: test-pass → test-fail (cc @Xanewok).
This was referenced Feb 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost