[experiment] expand: Stop using nonterminals when passing items to proc macro attributes#69594
Closed
petrochenkov wants to merge 1 commit intorust-lang:masterfrom
Closed
[experiment] expand: Stop using nonterminals when passing items to proc macro attributes#69594petrochenkov wants to merge 1 commit intorust-lang:masterfrom
petrochenkov wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
Author
|
@bors try @rust-timer queue |
Collaborator
|
Awaiting bors try build completion |
Collaborator
bors
added a commit
that referenced
this pull request
Feb 29, 2020
[experiment] expand: Stop using nonterminals when passing items to proc macro attributes Implement the suggestion from #69423 (comment). r? @ghost
petrochenkov
added
the
S-waiting-on-perf
Collaborator
|
☀️ Try build successful - checks-azure |
Collaborator
|
Queued b6be496 with parent e9bca51, future comparison URL. |
Contributor
Author
|
Not a perf improvement, isn't worth regressing pretty-printing. |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 7, 2020
rustc_expand: Factor out `Annotatable::into_tokens` to a separate method Minor refactoring salvaged from rust-lang#69594. r? @Centril
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 7, 2020
rustc_expand: Factor out `Annotatable::into_tokens` to a separate method Minor refactoring salvaged from rust-lang#69594. r? @Centril
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the suggestion from #69423 (comment).
r? @ghost