Rename def_span to guess_head_span#69866
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 26, 2020
Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
guess_head_span
branch
from
63f11de to
0ca1ac3
Compare
This was referenced Mar 9, 2020
eddyb
reviewed
Mar 10, 2020
eddyb
approved these changes
Mar 10, 2020
Member
|
@bors r+ |
Collaborator
|
📌 Commit 0ca1ac33dafcd7b2cb580fe0f91c6f07b1ccc84e has been approved by |
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-author
estebank
force-pushed
the
guess_head_span
branch
from
0ca1ac3 to
91611ca
Compare
Contributor
Author
|
@bors r=eddyb |
Collaborator
|
📌 Commit 91611ca7d53cbd5303fbfc883160c53aeceac211 has been approved by |
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Collaborator
|
☔ The latest upstream changes (presumably #69950) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
eddyb
suggested changes
Mar 12, 2020
Member
eddyb
left a comment
eddyb
left a comment
There was a problem hiding this comment.
r=me again only after resolving #69866 (comment)
estebank
force-pushed
the
guess_head_span
branch
from
91611ca to
5c54350
Compare
eddyb
approved these changes
Mar 23, 2020
Contributor
Author
|
@bors r=eddyb |
Collaborator
|
📌 Commit 5c543507759767ea3ab533d415ae0d3b33e3d232 has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
Member
|
@bors r- |
bors
added
S-waiting-on-author
Contributor
Author
|
This will conflict with #70227. |
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
guess_head_span
branch
from
5c54350 to
f18a6dc
Compare
Contributor
Author
|
rebased |
Collaborator
|
📌 Commit f18a6dc has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 26, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#69866 (Rename `def_span` to `guess_head_span`) - rust-lang#69878 (Tweak chained operators diagnostic) - rust-lang#70375 (avoid catching InterpError) - rust-lang#70386 (typeck: minor pattern typing improvements) - rust-lang#70389 (borrowck: prefer "value" over "`_`" in diagnostics) - rust-lang#70395 (Update cargo.) Failed merges: r? @ghost
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @eddyb