Replacing redundant internal iterators with external ones, part 1#6995
Closed
huonw wants to merge 3 commits intorust-lang:incomingfrom
Closed
Replacing redundant internal iterators with external ones, part 1#6995huonw wants to merge 3 commits intorust-lang:incomingfrom
huonw wants to merge 3 commits intorust-lang:incomingfrom
Conversation
Contributor
bors
added a commit
that referenced
this pull request
Jun 10, 2013
Continuation of #7015, and #6995. Rewrites the character-based `each_split` functions in `str` to use an iterator, removes a few redundant methods, and replaces all uses of `len`, `is_empty` and `slice` functions with the methods (and deletes the the functions). Update: Ok, this has turned into a major makeover for `str`, turning a lot of functions into methods, and removing redundant ones. Each commit is essentially a single such change. (Unscientific benchmarks suggest that the external `split_iter` is approximately 10% faster than the internal one. I'm not quite sure why this would be true.) (@thestinger is probably interested in this.)
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 13, 2022
Closes: rust-lang#6995 Signed-off-by: Federico Guerinoni <guerinoni.federico@gmail.com> Co-authored-by: Paolo Barbolini <paolo@paolo565.org>
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 13, 2022
Add borrow_as_ptr lint Closes: rust-lang#6995 - \[x] Followed [lint naming conventions][lint_naming] - \[x] Added passing UI tests (including committed `.stderr` file) - \[x] `cargo test` passes locally - \[x] Executed `cargo dev update_lints` - \[x] Added lint documentation - \[x] Run `cargo dev fmt` --- changelog: new lint: [`borrow_as_ptr`]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This kills the
each2,each2_mut,each_mutandeachi_mutfunctions instd::vecand replaces them with the appropriatestd::iteratorincantation.(The
each_mutetc methods fromold_iterare left untouched, so far.)