adjust Miri to needs of changed unwinding strategy#69999
adjust Miri to needs of changed unwinding strategy#69999bors merged 5 commits intorust-lang:masterfrom
Conversation
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors p=1 |
|
r? @oli-obk |
Mark-Simulacrum
left a comment
There was a problem hiding this comment.
Seems good, though I wasn't able to quite follow the miri changes.
src/librustc/mir/interpret/value.rs
Outdated
There was a problem hiding this comment.
These seem like they could be separate? But fine to leave them in too.
There was a problem hiding this comment.
I had to add from_i32 for the Miri side of this. So while I was at it I figured I might as well add the comments here, instead of making them a separate PR.
|
r=me with the comment updated. |
|
@bors r=oli-obk |
|
📌 Commit b450e1b has been approved by |
|
☀️ Test successful - checks-azure |
As expected, #67502 broke unwinding in Miri. To fix it we have to adjust parts of the engine and the panic runtime, which this PR does. The Miri-side changes are in rust-lang/miri#1227.
Cc @oli-obk @Aaron1011 @Mark-Simulacrum @Amanieu