Skip to content

Expand: nix all fatal errors#70074

Merged
bors merged 18 commits intorust-lang:masterfrom
Centril:unpanictry
Mar 24, 2020
Merged

Expand: nix all fatal errors#70074
bors merged 18 commits intorust-lang:masterfrom
Centril:unpanictry

Conversation

@Centril
Copy link
Contributor

@Centril Centril commented Mar 17, 2020 •
edited
Loading

Basically, we go after all .span_fatal / FatalError.raise() and similar things and remove them one by one until there are no fatal errors left.

r? @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 17, 2020
@bors

This comment has been minimized.

Sign in to view
petrochenkov
petrochenkov reviewed Mar 17, 2020
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2020
@Centril Centril mentioned this pull request Mar 18, 2020
Merged
@Centril Centril added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 18, 2020
@Centril
Copy link
Contributor Author

Centril commented Mar 18, 2020

@petrochenkov Addressed your comments. :)

@petrochenkov
Copy link
Contributor

petrochenkov commented Mar 18, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 18, 2020

📌 Commit 7d38b0f has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 18, 2020
@Centril
Rollup merge of rust-lang#70074 - Centril:unpanictry, r=petrochenkov
9318ffa 
Expand: nix all fatal errors

Basically, we go after all `.span_fatal` / `FatalError.raise()` and similar things and remove them one by one until there are no fatal errors left.

r? @petrochenkov
@Centril Centril mentioned this pull request Mar 18, 2020
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 18, 2020
@Centril
Rollup merge of rust-lang#70074 - Centril:unpanictry, r=petrochenkov
2dc0837 
Expand: nix all fatal errors

Basically, we go after all `.span_fatal` / `FatalError.raise()` and similar things and remove them one by one until there are no fatal errors left.

r? @petrochenkov
@Centril Centril mentioned this pull request Mar 18, 2020
Closed
@Centril Centril mentioned this pull request Mar 18, 2020
Merged
emilyalbini added a commit to emilyalbini/rust that referenced this pull request Mar 18, 2020
@emilyalbini
Rollup merge of rust-lang#70112 - Centril:rollup-gpi5tbq, r=Centril
11053ba 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#67749 (keyword docs for else and inkeyword docs for else and in.)
 - rust-lang#69139 (clean up E0308 explanation)
 - rust-lang#69189 (Erase regions in writeback)
 - rust-lang#69837 (Use smaller discriminants for generators)
 - rust-lang#69838 (Expansion-driven outline module parsing)
 - rust-lang#69839 (Miri error reform)
 - rust-lang#69899 (Make methods declared by `newtype_index` macro `const`)
 - rust-lang#69920 (Remove some imports to the rustc crate)
 - rust-lang#70075 (Fix repr pretty display)
 - rust-lang#70106 (Tidy: fix running rustfmt twice)

Failed merges:

 - rust-lang#70051 (Allow `hir().find` to return `None`)
 - rust-lang#70074 (Expand: nix all fatal errors)

r? @ghost
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 19, 2020
Centril added 18 commits March 24, 2020 06:28
@Centril
rustc_expand::base: nix panictry! uses
0f2d968
@Centril
nix panictry! in ParserAnyMacro::make
0a8db69
@Centril
nix remaining rustc_expand::panictry! uses.
b7909b2
@Centril
generic_extension: defatalize Error case
b0537e2
@Centril
defatalize BangProcMacro::expand
35cca74
@Centril
defatalize AttrProcMacro::expand
ce8880d
@Centril
defatalize ProcMacroDerive::expand
c1ef1b3 
Also remove ExtCtxt::struct_span_fatal.
@Centril
remove ExtCxt::struct_span_warn
ad26401
@Centril
mbe::transcribe: defatalize errors.
df9cec2
@Centril
defatalize compile_declarative_macro
1bfa248
@Centril
expand: nix unused method
2868045
@Centril
defatalize get_test_runner
0e0f931
@Centril
defatalize expand_test_or_bench
3979964
@Centril
expand: add recovery for parse_nt
21944b3
@Centril
expand: address review comments
d8080d8
@Centril
fix rebase fallout
d071035
@Centril
fix rebase fallout due to rust-lang#69497.
c415f12
@Centril
pacify missing sysroot spans issue
470e163
@Centril
Copy link
Contributor Author

Centril commented Mar 24, 2020

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Mar 24, 2020

📌 Commit 470e163 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 24, 2020
@Centril Centril mentioned this pull request Mar 24, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2020
@bors
Auto merge of rust-lang#70351 - Centril:rollup-tveoq3w, r=Centril
9d0ae58 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#68884 (Make the `type_of` return a generic type for generators)
 - rust-lang#69788 (Fix sequence of Type and Trait in optin-builtin-traits in Unstable Book)
 - rust-lang#70074 (Expand: nix all fatal errors)
 - rust-lang#70077 (Store idents for `DefPathData` into crate metadata)
 - rust-lang#70213 (traits/fulfill: allow `stalled_on` to track `ty::Const::Infer(_)` (unused yet).)
 - rust-lang#70259 (Use Reveal::All in MIR optimizations)
 - rust-lang#70284 (correctly handle const params in type_of)
 - rust-lang#70289 (Refactor `codegen`)

Failed merges:

r? @ghost
@bors bors merged commit 3d8b961 into rust-lang:master Mar 24, 2020
@Centril Centril deleted the unpanictry branch March 24, 2020 17:08
tesuji
tesuji reviewed Mar 25, 2020
View reviewed changes
src/test/ui/type/ascription/issue-47666.stderr
|
help: try using one of the enum's variants
|
LL | let _ = std::option::Option::None:Some(vec![0, 1]);
Copy link
Contributor

@tesuji tesuji Mar 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggestion is really weird.

Copy link
Contributor

@tesuji tesuji Mar 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open an issue: #70382

src/test/ui/type/ascription/issue-47666.stderr
|
help: try using the variant's enum
|
LL | let _ = Option:std::option::Option;

This comment was marked as duplicate.

Sign in to view

@Centril Centril mentioned this pull request Mar 26, 2020
Closed
@Centril Centril mentioned this pull request Apr 4, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

+1 more reviewer

@tesuji tesuji tesuji left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Centril @bors @petrochenkov @rust-highfive @Dylan-DPC-zz @tesuji