Skip to content

add basic support of OsStrExt for HermitCore#70134

Merged
bors merged 1 commit intorust-lang:masterfrom
hermit-os:osstrext
Apr 9, 2020
Merged

add basic support of OsStrExt for HermitCore#70134
bors merged 1 commit intorust-lang:masterfrom
hermit-os:osstrext

Conversation

@stlankes
Copy link
Contributor

@stlankes stlankes commented Mar 19, 2020

  • this patch increases the compatibility to other operating systems
  • in principle ffi.rs is derived from src/libstd/sys/unix/ext/ffi.rs

@stlankes
add basic support of OsStrExt for HermitCore
c643575 
this patch increases the compatibility to other operating systems
@rust-highfive
Copy link
Contributor

rust-highfive commented Mar 19, 2020

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2020
@joelpalmer joelpalmer added S-waiting-on-perf Status: Waiting on a perf run to be completed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 30, 2020
@Dylan-DPC-zz
Copy link

Dylan-DPC-zz commented Apr 6, 2020

r? @Amanieu

@rust-highfive rust-highfive assigned Amanieu and unassigned joshtriplett Apr 6, 2020
@Amanieu
Copy link
Member

Amanieu commented Apr 7, 2020

@rfcbot fcp merge

@Amanieu Amanieu added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 7, 2020
@Amanieu
Copy link
Member

Amanieu commented Apr 7, 2020

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Apr 7, 2020 •
edited by sfackler
Loading

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Apr 7, 2020
@dtolnay
Copy link
Member

dtolnay commented Apr 7, 2020

According to #65167 (comment) we don't need to pay much attention to changes that only affect this target.

@rfcbot fcp cancel
@bors r+

@rfcbot
Copy link

rfcbot commented Apr 7, 2020

@dtolnay proposal cancelled.

@bors
Copy link
Collaborator

bors commented Apr 7, 2020

📌 Commit c643575 has been approved by dtolnay

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Apr 7, 2020
@bors
Copy link
Collaborator

bors commented Apr 7, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@rfcbot rfcbot removed the disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. label Apr 7, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2020
dtolnay
dtolnay approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not reviewed beyond confirming that it only affects target_os = "hermit".

@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 8, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2020
@bors
Auto merge of rust-lang#70936 - Dylan-DPC:rollup-2ng3e5h, r=Dylan-DPC
d249d75 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#70134 (add basic support of OsStrExt for HermitCore)
 - rust-lang#70565 (Add inline attributes for functions used in the query system)
 - rust-lang#70828 (rustdoc: Don't try to load source files from external crates)
 - rust-lang#70870 (Fix abuses of tykind::err)
 - rust-lang#70906 (Suggest move for closures and async blocks in more cases.)
 - rust-lang#70912 (Do not suggest adding type param when `use` is already suggested)
 - rust-lang#70930 (add tracking issue to `VecDeque::make_contiguous`)

Failed merges:

r? @ghost
@bors bors merged commit cf0432a into rust-lang:master Apr 9, 2020
@mkroening mkroening deleted the osstrext branch December 11, 2022 19:09
@dtolnay dtolnay assigned dtolnay and unassigned Amanieu Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@stlankes @rust-highfive @Dylan-DPC-zz @Amanieu @rfcbot @dtolnay @bors @joshtriplett @joelpalmer