add basic IP support in HermitCore#70136
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 4, 2020
Merged
Conversation
Contributor
stlankes
commented
Mar 19, 2020
stlankes
commented
- add initial version to support sockets
- use TcpStream as test case
- HermitCore uses smoltcp as IP stack for pure Rust applications
- further functionalities (e.g. UDP support) will be added step by step
- in principle, the current PR is a revision of add basic IP support in HermitCore #69404
- add initial version to support sockets - use TcpStream as test case - HermitCore uses smoltcp as IP stack for pure Rust applications - further functionalities (e.g. UDP support) will be added step by step
Contributor
|
r? @shepmaster (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
joelpalmer
added
S-waiting-on-review
|
r? @dtolnay |
dtolnay
approved these changes
Apr 4, 2020
Member
dtolnay
left a comment
dtolnay
left a comment
There was a problem hiding this comment.
I haven't reviewed this beyond confirming that it only affects target_os = "hermit" which appears to be your project based on https://github.com/hermitcore/libhermit-rs/graphs/contributors.
Member
|
@bors r+ |
Collaborator
|
📌 Commit 57b7203 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-azure |
This was referenced Apr 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
