Have the per-query caches store the results on arenas#70674
Merged
bors merged 9 commits intorust-lang:masterfrom May 1, 2020
Merged
Have the per-query caches store the results on arenas#70674bors merged 9 commits intorust-lang:masterfrom
bors merged 9 commits intorust-lang:masterfrom
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
cjgillot
force-pushed
the
query-arena-all
branch
from
17fb3fd to
5196dcc
Compare
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Collaborator
|
☔ The latest upstream changes (presumably #70692) made this pull request unmergeable. Please resolve the merge conflicts. |
cjgillot
force-pushed
the
query-arena-all
branch
from
828930c to
148b529
Compare
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
cjgillot
changed the title
Contributor
|
@bors try @rust-timer queue |
Collaborator
|
Awaiting bors try build completion |
Collaborator
|
⌛ Trying commit c9f013d922cee0d0fefa70bac5de4d8427ad7340 with merge 5645cd25e3c73522f0b1ab615facc32c8537f062... |
Collaborator
|
☀️ Try build successful - checks-azure |
Collaborator
|
Queued 5645cd25e3c73522f0b1ab615facc32c8537f062 with parent 1b521f5, future comparison URL. |
Contributor
|
This appears to be a slight perf regression. |
Contributor
Author
|
Indeed, and I have no idea why. |
joelpalmer
added
S-waiting-on-review
|
@cjgillot any updates on this? |
cjgillot
force-pushed
the
query-arena-all
branch
from
c9f013d to
8fd36da
Compare
Collaborator
|
☔ The latest upstream changes (presumably #71044) made this pull request unmergeable. Please resolve the merge conflicts. |
cjgillot
force-pushed
the
query-arena-all
branch
from
8fd36da to
dc3a0e7
Compare
Collaborator
|
☔ The latest upstream changes (presumably #71215) made this pull request unmergeable. Please resolve the merge conflicts. |
cjgillot
force-pushed
the
query-arena-all
branch
from
dc3a0e7 to
4bcc53b
Compare
Collaborator
|
☔ The latest upstream changes (presumably #71292) made this pull request unmergeable. Please resolve the merge conflicts. |
cjgillot
force-pushed
the
query-arena-all
branch
from
4bcc53b to
d7d2185
Compare
Contributor
Author
|
Rebased. Can I get another perf run? |
Contributor
|
@bors try @rust-timer queue |
Collaborator
|
Awaiting bors try build completion |
Collaborator
|
⌛ Trying commit d7d2185 with merge 040acbcab104f84b25bd6be13b98182374fff2ab... |
Collaborator
|
☀️ Try build successful - checks-azure |
Collaborator
|
Queued 040acbcab104f84b25bd6be13b98182374fff2ab with parent fb5615a, future comparison URL. |
Collaborator
|
Finished benchmarking try commit 040acbcab104f84b25bd6be13b98182374fff2ab, comparison URL. |
Contributor
Author
|
Perf is neutral. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit d7d2185 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-azure |
This was referenced May 1, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 8, 2023
Remove QueryStorage::store_nocache This method was added in rust-lang#70674 but it doesn't seem to serve any purpose.
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Feb 9, 2023
Remove QueryStorage::store_nocache This method was added in rust-lang/rust#70674 but it doesn't seem to serve any purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR leverages the cache for each query to serve as storage area for the query results.
It introduces a new cache
ArenaCache, which moves the result to an arena,and only stores the reference in the hash map.
This allows to remove a sizeable part of the usage of the global
TyCtxtarena.I only migrated queries that already used arenas before.