Skip to content

macro_rules: NtLifetime cannot start with an identifier#70768

Merged
bors merged 1 commit intorust-lang:masterfrom
petrochenkov:macambig
Apr 5, 2020
Merged

macro_rules: NtLifetime cannot start with an identifier#70768
bors merged 1 commit intorust-lang:masterfrom
petrochenkov:macambig

Conversation

@petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Apr 4, 2020

Fixes #70446

@rust-highfive
Copy link
Contributor

rust-highfive commented Apr 4, 2020

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2020
@petrochenkov petrochenkov mentioned this pull request Apr 4, 2020
Closed
@petrochenkov petrochenkov added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 4, 2020
@Centril
Copy link
Contributor

Centril commented Apr 4, 2020

cc @mark-i-m and @pnkfelix

@mark-i-m
Copy link
Contributor

mark-i-m commented Apr 4, 2020

:lifetime metavariables must always have the apostrophe, right? i.e. I can't pass the a instead of 'a?

@petrochenkov
Copy link
Contributor Author

petrochenkov commented Apr 4, 2020

@mark-i-m
Yes, lifetime matcher expects a lifetime token with the single quote.

@mark-i-m
Copy link
Contributor

mark-i-m commented Apr 4, 2020

Ah, I didn't realize that there was a distinct lifetime token. I thought we just used an apostrophe token followed by ident. In that case, this PR LGTM.

@Centril
Copy link
Contributor

Centril commented Apr 4, 2020

r? @Centril @bors r=Centril,mark-i-m

@bors
Copy link
Collaborator

bors commented Apr 4, 2020

📌 Commit 106b30e has been approved by Centril,mark-i-m

@rust-highfive rust-highfive assigned Centril and unassigned cramertj Apr 4, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 5, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 5, 2020
@bors
Auto merge of rust-lang#70800 - Dylan-DPC:rollup-9jjoptp, r=Dylan-DPC
7b657d3 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#70635 (rustc_target: Some cleanup to `no_default_libraries`)
 - rust-lang#70748 (Do not disable field reordering on enums with big discriminant)
 - rust-lang#70752 (Add slice::fill)
 - rust-lang#70766 (use ManuallyDrop instead of forget inside collections)
 - rust-lang#70768 (macro_rules: `NtLifetime` cannot start with an identifier)
 - rust-lang#70783 (comment refers to removed type)

Failed merges:

r? @ghost
@bors bors merged commit d0dda18 into rust-lang:master Apr 5, 2020
@pnkfelix
Copy link
Contributor

pnkfelix commented Apr 9, 2020

Discussed in T-compiler meeting. beta-accepted.

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 9, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Apr 17, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2020
@bors
Auto merge of rust-lang#71258 - Mark-Simulacrum:beta-next, r=Mark-Sim…
062dea0 
…ulacrum

[beta] backports

This includes:
* Do not reuse post LTO products when exports change rust-lang#71131
* macro_rules: `NtLifetime` cannot start with an identifier rust-lang#70768
* Update RELEASES.md for 1.43.0 rust-lang#70354

r? @ghost
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 20, 2020
@petrochenkov petrochenkov deleted the macambig branch February 22, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Centril Centril

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

regression: local ambiguity: multiple parsing options: built-in NTs lifetime

8 participants

@petrochenkov @rust-highfive @Centril @mark-i-m @bors @pnkfelix @Mark-Simulacrum @cramertj