De-abuse TyKind::Error in pattern type checking#70932
Merged
bors merged 3 commits intorust-lang:masterfrom Apr 10, 2020
Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
8 tasks
Member
|
r? @Centril who I remember suggesting something similar in the past |
Centril
reviewed
Apr 8, 2020
Centril
added
S-waiting-on-author
Centril
reviewed
Apr 8, 2020
This comment has been minimized.
This comment has been minimized.
Contributor
Author
Centril
reviewed
Apr 9, 2020
Contributor
|
@bors delegate+ |
Collaborator
|
✌️ @mark-i-m can now approve this pull request |
Contributor
|
r=me with the remaining comments addressed. |
Contributor
Author
Collaborator
|
📌 Commit f2e4709 has been approved by |
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Contributor
Author
|
Also marking this as not-a-draft... does anyone know what bors will do if you try merge a draft? |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 9, 2020
De-abuse TyKind::Error in pattern type checking r? @eddyb cc rust-lang#70866 In particular, I would appreciate extra scrutiny over the soundness of these changes. Also, this will go a bit slowly because I'm going to use my other PR (rust-lang#70551) to check if I missed anything.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#70784 (Consider methods on fundamental `impl` when method is not found on numeric type) - rust-lang#70843 (Remove the Ord bound that was plaguing drain_filter) - rust-lang#70913 (Replace "rc"/"arc" lang items with Rc/Arc diagnostic items.) - rust-lang#70932 (De-abuse TyKind::Error in pattern type checking) - rust-lang#70952 (Clean up E0511 explanation) - rust-lang#70964 (rustc_session CLI lint parsing: mark a temporary hack as such) - rust-lang#70969 (Fix JSON file_name documentation for macros.) - rust-lang#70975 (Fix internal doc comment nits.) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @eddyb
cc #70866
In particular, I would appreciate extra scrutiny over the soundness of these changes.
Also, this will go a bit slowly because I'm going to use my other PR (#70551) to check if I missed anything.