Provide better compiler output when using ? on Option in fn returning Result and vice-versa#71141
Provide better compiler output when using ? on Option in fn returning Result and vice-versa#71141bors merged 2 commits intorust-lang:masterfrom
? on Option in fn returning Result and vice-versa#71141Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ecstatic-morse (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Please rebase on top of master (we don't allow merges in PRs) and squash your commits into a single commit. |
…ning `Result` and vice-versa
estebank
left a comment
estebank
left a comment
There was a problem hiding this comment.
Other than the nitpicks, r=me.
…ning `Result` and vice-versa
|
@estebank I pushed a new commit, tell me if I should squash it with the previous one |
|
@bors r+ |
|
📌 Commit fbc4168 has been approved by |
bors
added
S-waiting-on-bors
Provide better compiler output when using `?` on `Option` in fn returning `Result` and vice-versa Fixes rust-lang#71089
Provide better compiler output when using `?` on `Option` in fn returning `Result` and vice-versa Fixes rust-lang#71089
Provide better compiler output when using `?` on `Option` in fn returning `Result` and vice-versa Fixes rust-lang#71089
Provide better compiler output when using `?` on `Option` in fn returning `Result` and vice-versa Fixes rust-lang#71089
Rollup of 5 pull requests Successful merges: - rust-lang#70566 (Don't bail out before linting in generic contexts.) - rust-lang#71141 (Provide better compiler output when using `?` on `Option` in fn returning `Result` and vice-versa) - rust-lang#71149 (remove an impossible branch from check_consts) - rust-lang#71179 (fix more clippy warnings) - rust-lang#71191 (Clean up E0520 explanation) Failed merges: r? @ghost
5 participants
Fixes #71089