Kind-check closure freevars against destination builtin bounds.#7119
Closed
bblum wants to merge 2 commits intorust-lang:masterfrom
Closed
Kind-check closure freevars against destination builtin bounds.#7119bblum wants to merge 2 commits intorust-lang:masterfrom
bblum wants to merge 2 commits intorust-lang:masterfrom
Conversation
Contributor
|
General nit: Please add a comment at the top of each test saying the purpose of the test. Sorry about the test cast nits, but I've kind of got an unwritten Best Practice going on with respect to type-checker tests. Really helps with maintaining them over time. Anyway, the basic changes look good, so after correcting nits, feel free to give |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 22, 2021
Rustup r? `@ghost` changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis
Things this doesn't check for: