Merged
Conversation
clippy::{redundant_pattern_matching, clone_on_copy, iter_cloned_collect, option_as_ref_deref, match_ref_pats}
Introduce `enum RelocModel` instead.
The referenced `sanitizer-address/Makefile` no longer exists, so perhaps these options are no longer necessary as well. Even if they are still necessary, they should use `-C relocation-model=static` instead.
Cleanup and document `-C relocation-model` As the title says, this is mostly a refactoring and documentation. One potentially observable change here is that `-C relocation-model=default` now takes the default from the Rust target, rather than from the underlying LLVM target. In other words, `-C relocation-model=default` is now equivalent to not specifying the relocation model on command line at all. Apparently no one used that option because it has other bugs as well, e.g. PIC `default` wasn't treated as PIC in some places.
fix more clippy warnings
clippy::{redundant_pattern_matching, clone_on_copy, iter_cloned_collect, option_as_ref_deref, match_ref_pats}
r? @Dylan-DPC
Fix since attribute for nonzero_bitor impl's Added in rust-lang#69813, took a while to merge so the since attributes went out of date.
proc_macro: Fix since attributes for new Span methods Added in rust-lang#69041, took a while to merge so the since attributes went out of date.
Fix stable(since) attribute for BTreeMap::remove_entry Stabilized in rust-lang#70712. Maybe checking that the since attributes are added correctly should be automated through tidy? This is the third PR I'm opening that fixes a stable(since) attribute for something meant to be stabilized in 1.43 / 1.44 initially but then only stabilized in 1.45. (the other two are rust-lang#71571, rust-lang#71574)
Author
|
@bors r+ rollup=never p=5 |
Collaborator
|
📌 Commit aa9dc69 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit aa9dc69 with merge 3dd1ca6092ebbee163fb481554e2deec01877101... |
Collaborator
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
Author
|
@bors retry |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-azure |
Contributor
|
📣 Toolstate changed by #71579! Tested on commit 7f3b3df. 🎉 rustc-dev-guide on linux: test-fail → test-pass (cc @JohnTitor @amanjeev @spastorino @mark-i-m). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 26, 2020
Tested on commit rust-lang/rust@7f3b3df. Direct link to PR: <rust-lang/rust#71579> 🎉 rustc-dev-guide on linux: test-fail → test-pass (cc @JohnTitor @amanjeev @spastorino @mark-i-m).
This was referenced Apr 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
-C relocation-model#71490 (Cleanup and document-C relocation-model)Failed merges:
r? @ghost