Remove clippy from some leftover lists of "possibly failing" tools#71830
Merged
bors merged 1 commit intorust-lang:masterfrom May 5, 2020
Merged
Remove clippy from some leftover lists of "possibly failing" tools#71830bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
Member
|
This looks correct to me though I always get scared changing toolstate code... @bors r+ |
Collaborator
|
📌 Commit 675b585 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 3, 2020
…ulacrum Remove clippy from some leftover lists of "possibly failing" tools rust-lang#70655 successfully made clippy get built and tested on CI on every merge, but the lack of emitted toolstate info caused the toolstate to get updated to test-fail. We should remove clippy entirely from toolstate, as it now is always test-pass. The changes made in this PR reflect what we do for `rustdoc`, which is our preexisting tool that is gated on CI. r? @Mark-Simulacrum
This was referenced May 3, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 5, 2020
Rollup of 4 pull requests Successful merges: - rust-lang#69984 (Add Option to Force Unwind Tables) - rust-lang#71830 (Remove clippy from some leftover lists of "possibly failing" tools) - rust-lang#71894 (Suggest removing semicolon in last expression only if it's type is known) - rust-lang#71897 (Improve docs for embed-bitcode and linker-plugin-lto) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#70655 successfully made clippy get built and tested on CI on every merge, but the lack of emitted toolstate info caused the toolstate to get updated to test-fail. We should remove clippy entirely from toolstate, as it now is always test-pass.
The changes made in this PR reflect what we do for
rustdoc, which is our preexisting tool that is gated on CI.r? @Mark-Simulacrum