Merged
Conversation
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
Author
|
@bors r+ |
Collaborator
|
📌 Commit b65594fc0bd238e8557f524ca108df52fd5be69e has been approved by |
bors
added
the
S-waiting-on-bors
Contributor
Author
|
@bors p=1 since it's fixing toolstate |
Collaborator
|
⌛ Testing commit b65594fc0bd238e8557f524ca108df52fd5be69e with merge 69c873c2184b20057dc973eae53d29e2e60189ff... |
|
@bors retry (yielding priority for the stable release pr ) |
Collaborator
|
⌛ Testing commit b65594fc0bd238e8557f524ca108df52fd5be69e with merge 451ffb1a58d93b0c99e105df2e2231182b97f769... |
Collaborator
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
Contributor
Author
On it |
In addition to fixing the toolstate, this also changes the default compilation model to the out-of-process one, which should hopefully target considerable memory usage for long-running instances of the RLS.
Contributor
Author
|
r? @Mark-Simulacrum since this also changes some unified features in rustc-workspace-hack |
Member
|
Seems fine, thanks! @bors r+ |
Collaborator
|
📌 Commit b512b1c has been approved by |
bors
added
S-waiting-on-bors
Member
|
@bors treeclosed- |
Collaborator
|
⌛ Testing commit b512b1c with merge 7ddbbf1af5e1c93a1bf9c2cf2dae28ae3dd71cd2... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
the
S-waiting-on-review
|
spurious? cc @rust-lang/infra |
Member
|
Nope, this seems legit: |
kennytm
added
S-waiting-on-author
Contributor
Author
|
Oh I just pushed this myself locally, thanks @tmandry! |
Member
|
hah, I was worried it was outside working hours for you 😄 |
Member
|
Let's get this in. @bors r+ p=1 |
Collaborator
|
📌 Commit 3b8358e has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 3b8358e with merge 9a9ccb19891e727071a450f7cd4735e93d965828... |
|
@bors retry yield |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
Contributor
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
May 6, 2020
Tested on commit rust-lang/rust@43271a3. Direct link to PR: <rust-lang/rust#71875> 🎉 rls on windows: build-fail → test-pass (cc @Xanewok). 🎉 rls on linux: build-fail → test-pass (cc @Xanewok).
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 10, 2020
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 14, 2020
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 15, 2020
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 16, 2020
Update transitive dependency to work towards removing syn <1.0 dep This bumps a couple of transitive dependencies in hopes of eventually not transitively depending on syn <1.0 and friends. The only upstream changes that this is blocked on seems to be mattico/elasticlunr-rs#27 and rust-lang/mdBook#1210. While working on rust-lang#71875 I noticed we still use syn 0.15 here and there so this is a drive-by PR which aims to help with things a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to fixing the toolstate, this also changes the default
compilation model to the out-of-process one, which should hopefully
target considerable memory usage for long-running instances of the RLS.
Fixes #71753
r? @ghost