Merged
Conversation
LLVM TargetMachines default to using the (now-legacy) .ctors representation of init functions. Mixing .ctors and .init_array representations can cause issues when linking with lld. This happens in practice for: * Our profiling runtime which is currently implicitly built with .init_array since it is built by clang, which sets this field. * External C/C++ code that may be linked into the same process. To support legacy systems which may use .ctors, targets may now specify that they use .ctors via the use_ctors attribute which defaults to false. For debugging and manual control, -Z use-ctors-section=yes/no will allow manual override. Fixes: rust-lang#71233
upgrade chalk and use chalk-solve/chalk-ir/chalk-rust-ir Reintegrate chalk into rustc. r? @nikomatsakis cc. @rust-lang/wg-traits
Move tests from `test/run-fail` to UI Fixes rust-lang#65440 cc rust-lang#65865 rust-lang#65506 r? @nikomatsakis
rustllvm: Use .init_array rather than .ctors LLVM TargetMachines default to using the (now-legacy) .ctors representation of init functions. Mixing .ctors and .init_array representations can cause issues when linking with lld. This happens in practice for: * Our profiling runtime which is currently implicitly built with .init_array since it is built by clang, which sets this field. * External C/C++ code that may be linked into the same process. Fixes: rust-lang#71233
Simplify the `tcx.alloc_map` API This PR changes all functions that require manually locking the `alloc_map` to functions on `TyCtxt` that lock the map internally. In the same step we make the `TyCtxt::alloc_map` field private. r? @RalfJung
Remove ast::{Ident, Name} reexports.
The reexport of `Symbol` into `Name` confused me.
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
|
📌 Commit 366c178 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 366c178 with merge 96bbd80b1bf132494d0d44678214206b369d4edf... |
Collaborator
|
💥 Test timed out |
bors
added
S-waiting-on-review
Member
Author
|
cc @rust-lang/infra we got a timeout? @bors retry |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
Collaborator
Member
|
AFAICT macOS auto (dist-x86_64-apple builder got stuck checking out code (I can't see the actual log though). cc #71988 |
|
ye happens once in a while |
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
This was referenced May 9, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
test/run-failto UI #71185 (Move tests fromtest/run-failto UI)tcx.alloc_mapAPI #71508 (Simplify thetcx.alloc_mapAPI)Failed merges:
r? @ghost