Merged
Conversation
This is to provide a more explicit statement against a code pattern that many people end up coming with, since the reason of it being unsound comes from the badly known single-allocation validity rule. Providing that very pattern as a counter-example could help mitigate that. Co-authored-by: Ralf Jung <post@ralfj.de>
Intern predicates Implements the first step of rust-lang/compiler-team#285 Renames `ty::Predicate` to `ty::PredicateKind`, which is now interned. To ease the transition, `ty::Predicate` is now a struct containing a reference to `ty::PredicateKind`. r? @ghost
Don't `type_of` on trait assoc ty without default Fix rust-lang#72076.
…llaumeGomez Make intra-link resolve links for both trait and impl items Closes rust-lang#72340
…t_adjacent_slice_concat, r=RalfJung Improve documentation of `slice::from_raw_parts` This is to provide a more explicit statement against a code pattern that many people end up coming with, since the reason of it being unsound comes from the badly known single-allocation validity rule. Providing that very pattern as a counter-example could help mitigate that. See also: https://internals.rust-lang.org/t/pre-rfc-add-join-seq-method-to-slices-and-strs/11936/13 r? @RalfJung
…s, r=nikomatsakis Show default values for debug-assertions & debug-assertions-std
…r, r=kinnison Fix anchor display when hovering impl A little gif for the fixed behaviour:  r? @kinnison
…akis fix discriminant_value sign extension Fixes a regression introduced in rust-lang#70705 r? @nikomatsakis Cc @lcnr @oli-obk
Member
Author
Collaborator
|
📌 Commit 74b5c50 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-azure |
This was referenced May 22, 2020
This was referenced May 22, 2020
Merged
Contributor
|
This PR caused a rather large perf regression. Looking at the per-query results, the slowdown is in trait solving, so it is most likely #72055. There's one other candidate PR, #71718, whose perf run is not yet complete, but it is unlikely to have caused the regression. |
Member
Author
|
Probably the best way to measure this is to submit a PR that reverts the suspect, and perf-test that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
type_ofon trait assoc ty without default #72149 (Don'ttype_ofon trait assoc ty without default)slice::from_raw_parts#72350 (Improve documentation ofslice::from_raw_parts)Failed merges:
r? @ghost