Enforce unwind invariants#73133
Merged
bors merged 4 commits intorust-lang:masterfrom Jun 10, 2020
cofibrant:unwind-mir-validation
Merged
Enforce unwind invariants#73133bors merged 4 commits intorust-lang:masterfrom cofibrant:unwind-mir-validation
bors merged 4 commits intorust-lang:masterfrom
cofibrant:unwind-mir-validation
Conversation
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Contributor
jonas-schievink
left a comment
jonas-schievink
left a comment
There was a problem hiding this comment.
Looks pretty good! I'll run this with -Zvalidate-mir on the test suite to check if it finds anything. I don't think we need more testing than that (this is only an internal utility pass after all).
Contributor
Oh, right, this doesn't currently work |
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 9495ee2 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 10, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#72417 (Remove `RawVec::reserve_in_place`.) - rust-lang#73098 (Add Item::is_fake for rustdoc) - rust-lang#73122 (Resolve E0584 conflict) - rust-lang#73123 (Clean up E0647 explanation) - rust-lang#73133 (Enforce unwind invariants) - rust-lang#73148 (Fix a typo (size of the size)) - rust-lang#73149 (typo: awailable -> available) - rust-lang#73161 (Add mailmap entry) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a quick look at #72959. The failure message probably needs to be more detailed but I just wanted to check I got the right idea. I have no idea how to right a test for this either...
r? @jonas-schievink
Resolves #72959 (hypothetically)