Update bootstrap to rustc 1.45.0-beta.2 (1dc0f6d8e 2020-06-15)#73411
Merged
bors merged 2 commits intorust-lang:masterfrom Jun 21, 2020
Merged
Update bootstrap to rustc 1.45.0-beta.2 (1dc0f6d8e 2020-06-15)#73411bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors r+ |
Collaborator
|
📌 Commit 6f738a0 has been approved by |
bors
added
S-waiting-on-bors
Member
|
You might want to wait on decision whether #73184 is also accepted before updating bootstrap. |
Merged
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 20, 2020
Update bootstrap to rustc 1.45.0-beta.2 (1dc0f6d 2020-06-15) Pulls in changes from rust-lang#73326. Closes rust-lang#73286
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 20, 2020
Update bootstrap to rustc 1.45.0-beta.2 (1dc0f6d 2020-06-15) Pulls in changes from rust-lang#73326. Closes rust-lang#73286
Contributor
Author
Collaborator
|
📌 Commit bfb0e8d has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 20, 2020
…arth Rollup of 9 pull requests Successful merges: - rust-lang#72456 (Try to suggest dereferences on trait selection failed) - rust-lang#72788 (Projection bound validation) - rust-lang#72790 (core/time: Add Duration methods for zero) - rust-lang#73227 (Allow multiple `asm!` options groups and report an error on duplicate options) - rust-lang#73287 (lint: normalize projections using opaque types) - rust-lang#73291 (Pre-compute `LocalDefId` <-> `HirId` mappings and remove `NodeId` <-> `HirId` conversion APIs) - rust-lang#73378 (Remove use of specialization from librustc_arena) - rust-lang#73411 (Update bootstrap to rustc 1.45.0-beta.2 (1dc0f6d 2020-06-15)) - rust-lang#73443 (ci: allow gating GHA on everything but macOS) Failed merges: r? @ghost
tesuji
reviewed
Jun 21, 2020
Comment on lines
+1193
to
1195
| /// #![feature(inner_deref)] | ||
| /// let mut s = "HELLO".to_string(); | ||
| /// let mut x: Result<String, u32> = Ok("hello".to_string()); |
Contributor
There was a problem hiding this comment.
Was wondering why CI doesn't catch this?
Member
There was a problem hiding this comment.
CI failed to run doctests at all. This PR fixes that. See #73286.
Contributor
There was a problem hiding this comment.
Thanks. I should had read the link issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls in changes from #73326.
Closes #73286