Merged
Conversation
rustbot
added
C-enhancement
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
poliorcetics
force-pushed
the
static-keyword
branch
from
7ee5e4d to
b0f7568
Compare
poliorcetics
force-pushed
the
static-keyword
branch
from
b0f7568 to
2bbc2b3
Compare
LukasKalbertodt
suggested changes
Jun 28, 2020
Contributor
LukasKalbertodt
left a comment
LukasKalbertodt
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I left a couple of inline comments.
LukasKalbertodt
suggested changes
Jun 28, 2020
Contributor
LukasKalbertodt
left a comment
LukasKalbertodt
left a comment
There was a problem hiding this comment.
Sorry, another round of comments, but only tiny ones now! ^_^
LukasKalbertodt
approved these changes
Jun 28, 2020
Contributor
LukasKalbertodt
left a comment
LukasKalbertodt
left a comment
There was a problem hiding this comment.
Great, thanks for addressing my comment so quickly! And thanks again for the PR!
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 4224313 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 29, 2020
…sKalbertodt Document the static keyword Partial fix of rust-lang#34601. This documents the `static` keyword. It's basically a simplified version of the reference with more examples. @rustbot modify labels: T-doc,C-enhancement
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 29, 2020
…sKalbertodt Document the static keyword Partial fix of rust-lang#34601. This documents the `static` keyword. It's basically a simplified version of the reference with more examples. @rustbot modify labels: T-doc,C-enhancement
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 30, 2020
…sKalbertodt Document the static keyword Partial fix of rust-lang#34601. This documents the `static` keyword. It's basically a simplified version of the reference with more examples. @rustbot modify labels: T-doc,C-enhancement
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 30, 2020
…sKalbertodt Document the static keyword Partial fix of rust-lang#34601. This documents the `static` keyword. It's basically a simplified version of the reference with more examples. @rustbot modify labels: T-doc,C-enhancement
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 30, 2020
…sKalbertodt Document the static keyword Partial fix of rust-lang#34601. This documents the `static` keyword. It's basically a simplified version of the reference with more examples. @rustbot modify labels: T-doc,C-enhancement
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 1, 2020
…sKalbertodt Document the static keyword Partial fix of rust-lang#34601. This documents the `static` keyword. It's basically a simplified version of the reference with more examples. @rustbot modify labels: T-doc,C-enhancement
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 1, 2020
…sKalbertodt Document the static keyword Partial fix of rust-lang#34601. This documents the `static` keyword. It's basically a simplified version of the reference with more examples. @rustbot modify labels: T-doc,C-enhancement
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 1, 2020
…arth Rollup of 17 pull requests Successful merges: - rust-lang#72071 (Added detailed error code explanation for issue E0687 in Rust compiler.) - rust-lang#72369 (Bring net/parser.rs up to modern up to date with modern rust patterns) - rust-lang#72445 (Stabilize `#[track_caller]`.) - rust-lang#73466 (impl From<char> for String) - rust-lang#73548 (remove rustdoc warnings) - rust-lang#73649 (Fix sentence structure) - rust-lang#73678 (Update Box::from_raw example to generalize better) - rust-lang#73705 (stop taking references in Relate) - rust-lang#73716 (Document the static keyword) - rust-lang#73752 (Remap Windows ERROR_INVALID_PARAMETER to ErrorKind::InvalidInput from Other) - rust-lang#73776 (Move terminator to new module) - rust-lang#73778 (Make `likely` and `unlikely` const, gated by feature `const_unlikely`) - rust-lang#73805 (Document the type keyword) - rust-lang#73806 (Use an 'approximate' universal upper bound when reporting region errors) - rust-lang#73828 (Fix wording for anonymous parameter name help) - rust-lang#73846 (Fix comma in debug_assert! docs) - rust-lang#73847 (Edit cursor.prev() method docs in lexer) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix of #34601.
This documents the
statickeyword. It's basically a simplified version of the reference with more examples.@rustbot modify labels: T-doc,C-enhancement