Merged
Conversation
Previously, we were too conservative and `x.field = 4` was treated as a "use" of `x`.
Also, run RustFmt on the clashing_extern_fn test case and update stderrs.
Co-authored-by: Lukas Kalbertodt <lukas.kalbertodt@gmail.com>
…ave not been touched.
Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>
Add partition_point Add partition_point in C++. Although existing binary_search in rust does not suitable when the slice has multiple hits, this function returns exact point of partition. The definition of this function is very clear and able to accept general matter, therefore you can easily get index which you want like lower/upper_bound. rust-lang/rfcs#2184
…leywiser Const prop: erase all block-only locals at the end of every block I messed up this erasure in rust-lang#73656 (comment). I think it is too fragile to have the previous scheme. Let's benchmark the new scheme and see what happens. r? @wesleywiser cc @felix91gr
…ons, r=oli-obk Make liveness more precise for assignments to fields Previously, we were too conservative and `x.field = 4` was treated as a "use" of `x`. Now it neither kills `x` (since other fields of `x` may still be live) nor marks it as live. cc @jonas-schievink, who ran into this problem.
…r=oli-obk Add some `const_compare_raw_pointers`-related regression tests Closes rust-lang#71381 Closes rust-lang#71382 Closes rust-lang#71611 Closes rust-lang#72352 r? @oli-obk, the author of rust-lang#73398
Forward Hash::write_iN to Hash::write_uN The `Hasher::write_iN()` methods should forward to `Hasher::write_uN()`, because some Hasher implementations implement only the `write_uN()` variants, with the expectation that `write_iN()` will use the same implementation. Most notably, this is the case for the [FxHasher](https://github.com/rust-lang/rustc-hash/blob/5e09ea0a1c7ab7e4f9e27771f5a0e5a36c58d1bb/src/lib.rs#L111) used by rustc itself. This used to be the case previously, but was broken in rust-lang#59982. As the PR description makes no mention of this particular change, I assume it was unintentional. In a local test, this mitigates the regression from rust-lang#73526 on at least one test-case (cc @cuviper), because we're no longer at the mercy of `FxHasher::write()` getting inlined to get reasonable performance.
Rename two `Resolver` traits `trait Resolver` -> `trait ResolverExpand` for the resolver interface available from expansion. `trait Resolver` -> `trait ResolverAstLowering` for the resolver interface available from AST lowering. Addresses rust-lang#73587 (comment)
…eclarations, r=petrochenkov Rename clashing_extern_decl to clashing_extern_declarations. Rename clashing_extern_decl to clashing_extern_declarations to bring in-line with lint naming conventions. Fixes rust-lang#73802. r? @petrochenkov
Fix docstring typo
…tthewjasper Remove GlobalCtxt::enter_local
Member
Author
Collaborator
|
📌 Commit 117b734 has been approved by |
bors
added
the
S-waiting-on-bors
Member
|
FYI, #73800 was marked |
Collaborator
Collaborator
|
☀️ Test successful - checks-azure |
This was referenced Jun 28, 2020
Member
Author
|
@cuviper oh, shoot, i'm sorry, didn't notice that. We can do a perf run directly through try perhaps? |
Member
I'm not sure how to isolate one PR for perf after the fact, but it looks like a small change anyway. |
Member
Author
|
@cuviper oh good point lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
const_compare_raw_pointers-related regression tests #73795 (Add someconst_compare_raw_pointers-related regression tests)Resolvertraits #73813 (Rename twoResolvertraits)Failed merges:
r? @ghost