Merged
Conversation
Else, links to `char::foo` would point into `/path/to/src/libcore/std/primitive.char.html#method.foo`. Split out from rust-lang#73804.
If there are no `DerefMut` impl for the type.
They both produce less-than-desirable output (links going to docs.rust-lang.org), but I haven't figured out yet how to assert about them properly.
For the two of these tests that have a local `char` to link to, this behavior isn't what's expected, but is what's happening presently.
This reverts commit ee3a0f8.
Keep congruency with other parts, full word vector is rarely used.
Other terms are more inclusive and precise. Clippy still has a lint named "blacklisted-name", but renaming it would be a breaking change, so is left for future work. The target configuration option "abi-blacklist" has been depreciated and renamed to "unsupported-abis". The old name continues to work.
There don't seem to be any other compiletests that are 1) building a standalone "no_core" create and then 2) trying to link against it. There seems to be a platform-specific limitation in doing so: ``` 2020-07-08T16:07:42.9419409Z = note: Creating library D:\a\rust\rust\build\i686-pc-windows-msvc\test\rustdoc\intra-link-prim-methods-external-core\auxiliary\my_core.dll.lib and object D:\a\rust\rust\build\i686-pc-windows-msvc\test\rustdoc\intra-link-prim-methods-external-core\auxiliary\my_core.dll.exp 2020-07-08T16:07:42.9419810Z LINK : error LNK2001: unresolved external symbol __DllMainCRTStartup@12 2020-07-08T16:07:42.9420032Z D:\a\rust\rust\build\i686-pc-windows-msvc\test\rustdoc\intra-link-prim-methods-external-core\auxiliary\my_core.dll : fatal error LNK1120: 1 unresolved externals ``` Possibly this could be resolved by adding a `__DllMainCRTStartup` or `__DllMainCRTStartup@12` symbol in an architecture- and platform-specific way.
There are some structures that are called "globals", but are they global to a compilation session, and not truly global. I have always found this highly confusing, so this commit renames them as "session globals" and adds a comment explaining things. Also, the commit fixes an unnecessary nesting of `set()` calls `src/librustc_errors/json/tests.rs`
Do not trigger on correct type ascription expressions with trailing operators and _do_ trigger on likely path typos where a turbofish is used. On likely path typos, remove note explaining type ascription.
… r=Dylan-DPC Fixing broken link for the Eq trait Fixes rust-lang#73233.
…llaumeGomez,jyn514 Allow for parentheses after macro intra-doc-links None
…istic, r=petrochenkov Tweak `::` -> `:` typo heuristic and reduce verbosity Do not trigger on correct type ascription expressions with trailing operators and _do_ trigger on likely path typos where a turbofish is used. On likely path typos, remove note explaining type ascription. Clean up indentation. r? @petrochenkov
Member
Author
Collaborator
|
📌 Commit 9353e21 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 9353e21 with merge 2ab5fd715eccffa67a436fe498c18a0d01122ad9... |
Member
Author
|
@bors treeclosed=5 i plan to be online today, might as well close the tree until some rollups land. Feel free to @ me if i forget, or reopen the tree |
Collaborator
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
Member
|
Member
Author
|
Hmm unsure which PR that is |
Member
|
It succeeded on GHA, just not on Azure. |
Member
Author
|
@bors retry hmmm, googling that error shows it might be a disk space issue |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jul 10, 2020
Tested on commit rust-lang/rust@e59b08e. Direct link to PR: <rust-lang/rust#74195> 🎉 miri on windows: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung). 🎉 miri on linux: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
This was referenced Jul 10, 2020
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
&mut selfmethods from Deref in sidebar if there are noDerefMutimpl for the type. #74107 (Hide&mut selfmethods from Deref in sidebar if there are noDerefMutimpl for the type.)::->:typo heuristic and reduce verbosity #74188 (Tweak::->:typo heuristic and reduce verbosity)Failed merges:
r? @ghost