Don't allow DESTDIR to influence LLVM builds#74252
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
eddyb
left a comment
eddyb
left a comment
There was a problem hiding this comment.
This may work as a workaround but I believe x.py build should not expose DESTDIR to the LLVM build, i.e. it should unset that env var for the relevant commands, which will remove the need to have RUST_DESTDIR at all.
This seems to be a combination of oversight and probably x.py install not being used to also do the build step, most of the time (think make && make DESTDIR=$PKG_OUT_DIR install).
|
Yes, I think @eddyb is right that the preferred approach would be to unset the env variable when invoking cmake during our LLVM installation/building, since we should be in full control of where LLVM is installed (vs. Rust itself, which I guess makes sense that DESTDIR should affect that). |
When running a command like `DESTDIR=foo x.py install` in a completely clean build directory, this will cause LLVM to be installed into `DESTDIR`, which then causes the build to fail later when it attempts to *use* those LLVM files.
shepmaster
force-pushed
the
bootstrap-rust-destdir
branch
from
84d7d06 to
9741fbd
Compare
shepmaster
changed the title
RUST_DESTDIR, a scoped alternative to DESTDIRDESTDIR to influence LLVM builds
|
Updated to unset |
|
@bors r+ |
|
📌 Commit 9741fbd has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 20, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
…arth Rollup of 11 pull requests Successful merges: - rust-lang#73759 (Add missing Stdin and StdinLock examples) - rust-lang#74211 (Structured suggestion when not using struct pattern) - rust-lang#74228 (Provide structured suggestion on unsized fields and fn params) - rust-lang#74252 (Don't allow `DESTDIR` to influence LLVM builds) - rust-lang#74263 (Slight reorganization of sys/(fast_)thread_local) - rust-lang#74271 (process_unix: prefer i32::*_be_bytes over manually shifting bytes) - rust-lang#74272 (pprust: support multiline comments within lines) - rust-lang#74332 (Update cargo) - rust-lang#74334 (bootstrap: Improve wording on docs for `verbose-tests`) - rust-lang#74336 (typeck: use `item_name` in cross-crate packed diag) - rust-lang#74340 (lint: use `transparent_newtype_field` to avoid ICE) Failed merges: r? @ghost
workingjubilee
added
the
A-LLVM
7 participants
When running a command like
DESTDIR=foo x.py installin a completelyclean build directory, this will cause LLVM to be installed into
DESTDIR, which then causes the build to fail later when it attemptsto use those LLVM files.