Remove some redundant parts from unrolled_find_u16s#74289
Merged
bors merged 3 commits intorust-lang:masterfrom Aug 8, 2020
Merged
Remove some redundant parts from unrolled_find_u16s#74289bors merged 3 commits intorust-lang:masterfrom
unrolled_find_u16s#74289bors merged 3 commits intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
A very small improvement in codegen with opt-level <=2: https://rust.godbolt.org/z/8fMGav . |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
☔ The latest upstream changes (presumably #73265) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
Author
|
r? @LukasKalbertodt for review or reassignment |
LukasKalbertodt
approved these changes
Aug 8, 2020
Contributor
LukasKalbertodt
left a comment
LukasKalbertodt
left a comment
There was a problem hiding this comment.
Looks like a nice improvement :)
Thanks!
Contributor
|
As this is platform dependent code, I assume this will not do anything about compiler performance? So I will not @bors r+ |
Collaborator
|
📌 Commit f55e4d0 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See each commit message for details.
r? @wesleywiser from old PR #67705 .