Initialize default providers only once#74347
Conversation
|
LGTM, let's make sure this is a perf noop: |
|
Awaiting bors try build completion |
|
⌛ Trying commit 7798fe1ed63c51bc95c0a4601b9251e0f9ff4f31 with merge cdd0504ed68bfd479ea4ea5b1a1336730a76c2e9... |
|
☀️ Try build successful - checks-actions, checks-azure |
|
Queued cdd0504ed68bfd479ea4ea5b1a1336730a76c2e9 with parent 23744c8, future comparison URL. |
|
Finished benchmarking try commit (cdd0504ed68bfd479ea4ea5b1a1336730a76c2e9): comparison url. |
|
No change in instructions, wall time is all over the place but looking at the last noise run that might be normal? |
|
Yeah you can generally ignore wall-time. The important thing to look at here is @bors r+ |
|
📌 Commit 7798fe1ed63c51bc95c0a4601b9251e0f9ff4f31 has been approved by |
bors
added
the
S-waiting-on-bors
This avoids copying a new `Providers` struct for each downstream crate that wants to use it.
jyn514
force-pushed
the
ive-got-a-small-query-for-you
branch
from
7798fe1 to
f6764c4
Compare
|
@bors r=eddyb still queueing this in case it gets rolled up |
|
📌 Commit f6764c4 has been approved by |
…arth Rollup of 14 pull requests Successful merges: - rust-lang#72973 (RISC-V GNU/Linux as host platform) - rust-lang#73918 (Clean up E0715 explanation) - rust-lang#73959 (Clean up E0716 explanation) - rust-lang#74119 (Remove `Compiler::compile()`.) - rust-lang#74196 (Add option to collapse automatically implementors) - rust-lang#74218 (Add margin after doc search results) - rust-lang#74276 (improve DiscriminantKind handling) - rust-lang#74291 (Added docs for `From<c_int>` for `ExitStatus`) - rust-lang#74294 (Update cross-compilation README) - rust-lang#74337 (Handle case of incomplete local ty more gracefully) - rust-lang#74344 (Remove string comparison and use diagnostic item instead) - rust-lang#74347 (Initialize default providers only once) - rust-lang#74353 (Edit docs for rustc_middle::dep_graph::dep_node) - rust-lang#74374 (Add a 1.45 release note on lto vs. embed-bitcode) Failed merges: - rust-lang#74251 (Teach bootstrap about target files vs target triples) r? @ghost
6 participants
This avoids copying a new
Providersstruct for each downstream cratethat wants to use it.
Follow-up to #74283 without the perf hit.
r? @eddyb