Some Symbol related improvements#74357
Merged
bors merged 6 commits intorust-lang:masterfrom Jul 17, 2020
Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
Jul 15, 2020
Contributor
|
r=me with documentation nit resolved. |
nnethercote
force-pushed
the
symbol-related-improvements
branch
from
621cc66 to
b24bcc8
Compare
Contributor
Author
|
@bors r=oli-obk, rollup=iffy Iffy because it's fairly large. |
Collaborator
|
📌 Commit b24bcc883ac9b61217c845c7d8baef8c2889ac4f has been approved by |
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 5, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Contributor
Author
|
I don't think this will have a perf effect, but let's check to be sure. @bors try @rust-timer queue |
Collaborator
|
🙅 Please do not |
Collaborator
|
Awaiting bors try build completion |
Contributor
Author
|
@bors r- |
bors
added
S-waiting-on-author
Contributor
Author
|
@bors try |
Collaborator
|
⌛ Trying commit b24bcc883ac9b61217c845c7d8baef8c2889ac4f with merge 4d6f6e62bd34546e4c64b9684af62346c5de2858... |
Collaborator
|
☀️ Try build successful - checks-actions, checks-azure |
Collaborator
|
Queued 4d6f6e62bd34546e4c64b9684af62346c5de2858 with parent 7e11379, future comparison URL. |
Collaborator
|
Finished benchmarking try commit (4d6f6e62bd34546e4c64b9684af62346c5de2858): comparison url. |
Contributor
|
perf looks clean with potential small improvements, just needs a rebase |
The `lifetimes` field is always empty. This commit removes it, and renames the type as `Bounds`.
It's equivalent to `Ident::from_str_and_span`. The commit also introduces some more static symbols so that `Ident::new` can be used in various places instead of `Ident::from_str_and_span`. The commit also changes `Path::path` from a `&str` to a `Symbol`, which then allows the lifetime annotation to be removed from `Ty`. Also, the use of `Symbol` in `Bounds` removes the need for its lifetime annotation.
It's intended only for very temporary use.
This replaces the need for the `description` and `details` symbols in `UnsafetyViolation`, which are static. As a result some `Symbol::as_str()` calls are no longer necessary, which is nice.
nnethercote
force-pushed
the
symbol-related-improvements
branch
from
b24bcc8 to
a4ba181
Compare
Contributor
Author
|
I rebase. @bors r=oli-obk |
Collaborator
|
📌 Commit a4ba181 has been approved by |
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 5, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 16, 2020
…ents, r=oli-obk Some `Symbol` related improvements These commits make things nicer and avoid some `Symbol::as_str()` calls. r? @oli-obk
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 16, 2020
…ents, r=oli-obk Some `Symbol` related improvements These commits make things nicer and avoid some `Symbol::as_str()` calls. r? @oli-obk
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 16, 2020
…ents, r=oli-obk Some `Symbol` related improvements These commits make things nicer and avoid some `Symbol::as_str()` calls. r? @oli-obk
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 17, 2020
…ents, r=oli-obk Some `Symbol` related improvements These commits make things nicer and avoid some `Symbol::as_str()` calls. r? @oli-obk
This was referenced Jul 17, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 17, 2020
…arth Rollup of 8 pull requests Successful merges: - rust-lang#73101 (Resolve items for cross-crate imports relative to the original module) - rust-lang#73269 (Enable some timeouts in SGX platform) - rust-lang#74033 (Add build support for Cargo's build-std feature.) - rust-lang#74351 (Do not render unstable items for rustc doc) - rust-lang#74357 (Some `Symbol` related improvements) - rust-lang#74371 (Improve ayu rustdoc theme) - rust-lang#74386 (Add RISC-V GNU/Linux to src/tools/build-manifest as a host platform) - rust-lang#74398 (Clean up E0723 explanation) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits make things nicer and avoid some
Symbol::as_str()calls.r? @oli-obk