Separate missing_doc_code_examples from intra-doc links#74855
Separate missing_doc_code_examples from intra-doc links#74855bors merged 3 commits intorust-lang:masterfrom
missing_doc_code_examples from intra-doc links#74855Conversation
|
Some changes occurred in intra-doc-links. cc @jyn514 |
rust-highfive
added
the
S-waiting-on-review
jyn514
added
C-cleanup
Manishearth
left a comment
Manishearth
left a comment
There was a problem hiding this comment.
Seems good to me. Would be nice to have some comments saying why the pass is badly named right now until we fix it.
(Perhaps linking to an issue to properly fix the pass)
There was a problem hiding this comment.
We should probably rename this pass and module.
There was a problem hiding this comment.
I'm not sure I follow - this pass still looks for doc-tests in private items, it just also looks for public items as well. Were you imagining something like doc_test_lints.rs?
There was a problem hiding this comment.
Renamed the file, moved look_for_tests to this file, and added a short doc-comment explaining that it runs two different lints.
These two lints have no relation other than both being nightly-only. This allows stabilizing intra-doc links without stabilizing missing_doc_code_examples.
|
@bors r+ We should file a followup about regularizing the lint names, renaming the pass, and making both of these nightly-only. |
|
📌 Commit c3f5556 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
This fixes a regression introduced in rust-lang#74855.
Fix swapped stability attributes for rustdoc lints This fixes a regression introduced in rust-lang#74855. Previously, `missing_doc_code_examples` would be run on stable and `private_doc_tests` would only be run on nightly. Now, it correctly does the reverse. Closes rust-lang#75951. r? @ehuss
This fixes a regression introduced in rust-lang#74855.
5 participants
These two lints have no relation other than both being nightly-only.
This allows stabilizing intra-doc links without stabilizing
missing_doc_code_examples.Fixes one of the issues spotted by @ollie27 in #74430 (comment).
r? @Manishearth