Check that we don't use Rvalue::Aggregate after the deaggregator#75562
Merged
bors merged 6 commits intorust-lang:masterfrom Aug 20, 2020
Merged
Check that we don't use Rvalue::Aggregate after the deaggregator#75562bors merged 6 commits intorust-lang:masterfrom
Rvalue::Aggregate after the deaggregator#75562bors merged 6 commits intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
RalfJung
reviewed
Aug 15, 2020
RalfJung
reviewed
Aug 15, 2020
RalfJung
reviewed
Aug 15, 2020
RalfJung
reviewed
Aug 15, 2020
RalfJung
reviewed
Aug 15, 2020
RalfJung
reviewed
Aug 15, 2020
oli-obk
force-pushed
the
const_prop_no_aggregates
branch
2 times, most recently
from
79f8c97 to
9f50e14
Compare
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
oli-obk
force-pushed
the
const_prop_no_aggregates
branch
from
744e74d to
de7c836
Compare
Member
|
(The force-push + squashing in one go makes it impossible to only review the delta since the last time I checked...) |
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
RalfJung
reviewed
Aug 18, 2020
Contributor
Author
I had to rebase, but yea, I should have made separate commits for the changes since then. |
oli-obk
force-pushed
the
const_prop_no_aggregates
branch
from
d2494de to
03d38d4
Compare
RalfJung
reviewed
Aug 18, 2020
RalfJung
approved these changes
Aug 18, 2020
Member
RalfJung
left a comment
RalfJung
left a comment
There was a problem hiding this comment.
Validator and MIR pass management LGTM now.
I can't check the changes in ConstProp and generator lowering, and I don't know if the mir-opt changes make sense.
bjorn3
reviewed
Aug 18, 2020
wesleywiser
approved these changes
Aug 20, 2020
Member
wesleywiser
left a comment
wesleywiser
left a comment
There was a problem hiding this comment.
I left a few minor comments but this looks great to me overall!
Member
|
Since this impacts mir-optimizations: @bors rollup=never |
Co-authored-by: Wesley Wiser <wwiser@gmail.com>
Member
|
@bors r+ |
Collaborator
|
📌 Commit dcc2027 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
This was referenced Aug 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #75481
r? @wesleywiser
cc @RalfJung (modified the validator)