Conversation
Contributor
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
Author
Contributor
|
I am wondering whether we shouldn't add libz to all cross-compiled builds for all platforms by default, now that we know that that the LLVM option is enabled by default? This will increase the likelihood that cross-compiling rustc will work on any platform. Do we know platforms that do not ship libz? windows perhaps? |
Member
Author
|
@nielx Looking at CI logs in case of Windows this works like that:
|
Contributor
The issue remains that this will in principle break any cross compiling rustc for any platform that has libz on it. I see five options:
Personally, while I cannot quantify it definitively, solution 2 sounds like it will get most targets right without any additional manual work/patches, so that's where my preference would be. If we want to be on the safe side, we could go for option 5. Unfortunately I do not seem to be able to find the CI logs, do do some investigation, but that's where I would go next. |
Member
|
I agree that option 2 seems like the best way, and we should surface the option in config.toml (probably in a target-specific section). |
Member
|
That said, I'm going to r+ this since it does seem like a net-improvement to me for the time being. @bors r+ |
Collaborator
|
📌 Commit 32f02a389ab2e5c6faa714c38a99e53a02235eff has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
☔ The latest upstream changes (presumably #75625) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Member
Author
|
Rebased. |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 985df3d has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 985df3d with merge 70185dcbd56502c8276462026a6b27b0005619bf... |
Member
Author
|
This is going to fail because of https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/MSVC.20on.20CI.20has.20broke |
Collaborator
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Member
|
@bors retry |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
Closed
inferiorhumanorgans
pushed a commit
to inferiorhumanorgans/rust
that referenced
this pull request
Aug 8, 2023
On native builds `llvm-config` picks up `zlib` and this gets pased into the rust build tools, but on cross builds `llvm-config` is explicitly ignored as it contains information for the host system and cannot be trusted to be accurate for the target system. Both DragonFly and Solaris contain `zlib` in the base system, so this is both a safe assumption and required for a successful cross build unless `zlib` support is disabled in LLVM. This is more or less in the same vein as rust-lang#75713 and rust-lang#75655.
fmease
added a commit
to fmease/rust
that referenced
this pull request
Sep 2, 2023
…-libz, r=cuviper rustc_llvm: Link to `zlib` on dragonfly and solaris On native builds `llvm-config` picks up `zlib` and this gets pased into the rust build tools, but on cross builds `llvm-config` is explicitly ignored as it contains information for the host system and cannot be trusted to be accurate for the target system. Both DragonFly and Solaris contain `zlib` in the base system, so this is both a safe assumption and required for a successful cross build unless `zlib` support is disabled in LLVM. This is more or less in the same vein as rust-lang#75713 and rust-lang#75655.
fmease
added a commit
to fmease/rust
that referenced
this pull request
Sep 2, 2023
…-libz, r=cuviper rustc_llvm: Link to `zlib` on dragonfly and solaris On native builds `llvm-config` picks up `zlib` and this gets pased into the rust build tools, but on cross builds `llvm-config` is explicitly ignored as it contains information for the host system and cannot be trusted to be accurate for the target system. Both DragonFly and Solaris contain `zlib` in the base system, so this is both a safe assumption and required for a successful cross build unless `zlib` support is disabled in LLVM. This is more or less in the same vein as rust-lang#75713 and rust-lang#75655.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 2, 2023
…-libz, r=cuviper rustc_llvm: Link to `zlib` on dragonfly and solaris On native builds `llvm-config` picks up `zlib` and this gets pased into the rust build tools, but on cross builds `llvm-config` is explicitly ignored as it contains information for the host system and cannot be trusted to be accurate for the target system. Both DragonFly and Solaris contain `zlib` in the base system, so this is both a safe assumption and required for a successful cross build unless `zlib` support is disabled in LLVM. This is more or less in the same vein as rust-lang#75713 and rust-lang#75655.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetBSD Docker dist job passed locally.