Move Vec UI tests to unit tests when possible#76718
Merged
bors merged 5 commits intorust-lang:masterfrom Nov 5, 2020
Merged
Conversation
rustbot
added
A-testsuite
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit 44b7cc4212d5527fe936074d4d8f08d7cb5907ac has been approved by |
bors
added
S-waiting-on-bors
Contributor
Author
|
I'm sorry, I forgot to add WIP to the title, I'm not done at all with this PR |
Contributor
Author
|
It can be merged and I can open another but that would separate related work across two PRs |
poliorcetics
changed the title
Member
|
@bors r- |
bors
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
I will look into before the end of the week, I'm currently busy with the survey's translation. |
poliorcetics
force-pushed
the
vec-ui-to-unit-test
branch
from
ac29e6e to
8b799b2
Compare
This comment has been minimized.
This comment has been minimized.
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
poliorcetics
force-pushed
the
vec-ui-to-unit-test
branch
from
6d561f9 to
1bdee96
Compare
Contributor
Author
|
I think this can be merged as is, more work can be done in another PR without problems and hitting more merge conflicts sounds painful. |
Member
|
@bors r+ rollup For posterity, |
Collaborator
|
📋 Looks like this PR is still in progress, ignoring approval. Hint: Remove WIP from this PR's title when it is ready for review. |
jyn514
changed the title
Member
|
@bors r+ |
Collaborator
|
📌 Commit 1bdee96 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 5, 2020
…=jyn514 Move Vec UI tests to unit tests when possible Helps with rust-lang#76268. I'm moving the tests using `Vec` or `VecDeque`. `@rustbot` modify labels: A-testsuite C-cleanup T-libs
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 5, 2020
…=jyn514 Move Vec UI tests to unit tests when possible Helps with rust-lang#76268. I'm moving the tests using `Vec` or `VecDeque`. ``@rustbot`` modify labels: A-testsuite C-cleanup T-libs
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Nov 5, 2020
…=jyn514 Move Vec UI tests to unit tests when possible Helps with rust-lang#76268. I'm moving the tests using `Vec` or `VecDeque`. ```@rustbot``` modify labels: A-testsuite C-cleanup T-libs
This was referenced Nov 5, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 5, 2020
Rollup of 15 pull requests Successful merges: - rust-lang#76718 (Move Vec UI tests to unit tests when possible) - rust-lang#78093 (Clean up docs for 'as' keyword) - rust-lang#78425 (Move f64::NAN ui tests into `library`) - rust-lang#78465 (Change as_str → to_string in proc_macro::Ident::span() docs) - rust-lang#78584 (Add keyboard handling to the theme picker menu) - rust-lang#78716 (Array trait impl comment/doc fixes) - rust-lang#78727 ((rustdoc) fix test for trait impl display) - rust-lang#78733 (fix a couple of clippy warnings:) - rust-lang#78735 (Simplify the implementation of `get_mut` (no unsafe)) - rust-lang#78738 (Move range in ui test to ops test in library/core) - rust-lang#78739 (Fix ICE on type error in async function) - rust-lang#78742 (make intern_const_alloc_recursive return error) - rust-lang#78756 (Update cargo) - rust-lang#78757 (Improve and clean up some intra-doc links) - rust-lang#78758 (Fixed typo in comment) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps with #76268.
I'm moving the tests using
VecorVecDeque.@rustbot modify labels: A-testsuite C-cleanup T-libs