Avoiding unnecesary allocations at rustc_errors#76846
Merged
bors merged 2 commits intorust-lang:masterfrom Sep 21, 2020
zzau13:master
Merged
Avoiding unnecesary allocations at rustc_errors#76846bors merged 2 commits intorust-lang:masterfrom zzau13:master
bors merged 2 commits intorust-lang:masterfrom
zzau13:master
Conversation
Contributor
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
zzau13
changed the title
rustc_errors/emitter
jyn514
added
C-cleanup
tesuji
reviewed
Sep 18, 2020
Member
|
Could you squash the last commit that changes code style? |
Contributor
Author
Done, Thanks for your time!! |
davidtwco
approved these changes
Sep 18, 2020
Member
|
Thanks for the contribution! @bors r+ |
Collaborator
|
📌 Commit 28cfa97 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 19, 2020
Avoiding unnecesary allocations at rustc_errors Simplify the code avoiding allocations with easy alternative
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 19, 2020
Avoiding unnecesary allocations at rustc_errors Simplify the code avoiding allocations with easy alternative
This was referenced Sep 19, 2020
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 19, 2020
Avoiding unnecesary allocations at rustc_errors Simplify the code avoiding allocations with easy alternative
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 21, 2020
Avoiding unnecesary allocations at rustc_errors Simplify the code avoiding allocations with easy alternative
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 21, 2020
Rollup of 13 pull requests Successful merges: - rust-lang#76135 (Stabilize some Option methods as const) - rust-lang#76628 (Add sample defaults for config.toml ) - rust-lang#76846 (Avoiding unnecesary allocations at rustc_errors) - rust-lang#76867 (Use intra-doc links in core/src/iter when possible) - rust-lang#76868 (Finish moving to intra doc links for std::sync) - rust-lang#76872 (Remove DeclareMethods) - rust-lang#76936 (Add non-`unsafe` `.get_mut()` for `Unsafecell`) - rust-lang#76958 (Replace manual as_nanos and as_secs_f64 reimplementations) - rust-lang#76959 (Replace write_fmt with write!) - rust-lang#76961 (Add test for issue rust-lang#34634) - rust-lang#76962 (Use const_cstr macro in consts.rs) - rust-lang#76963 (Remove unused static_assert macro) - rust-lang#77000 (update Miri) Failed merges: r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the code avoiding allocations with easy alternative