ICEs should print the top of the query stack#76920

hosseind75 · 2020-09-19T13:22:47Z

rust-highfive · 2020-09-19T13:22:50Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

oli-obk · 2020-09-19T13:34:51Z

This should affect a ui test, did you --bless?

Also I only now understand your question... Yea we should keep printing the full stack if RUST_BACKTRACE is set

hosseind75 · 2020-09-19T13:44:39Z

This should affect a ui test, did you --bless?

Also I only now understand your question... Yea we should keep printing the full stack if RUST_BACKTRACE is set

ahh no sorry I forgot, I will add git hook to run it automatically before every commit

ok I will fix the change about RUST_BACKTRACE

jyn514 · 2020-09-19T13:54:48Z

I think you meant to link to #70953

jyn514 · 2020-09-19T13:55:35Z

ahh no sorry I forgot, I will add git hook to run it automatically before every commit

cc #76356

hosseind75 · 2020-09-19T14:01:52Z

ahh no sorry I forgot, I will add git hook to run it automatically before every commit

cc #76356

thanks

compiler/rustc_driver/src/lib.rs

oli-obk · 2020-09-19T14:15:50Z

Note that for ui tests you do need a full build, so ./x.py test --bless src/test/ui. You can speed it up with --test-args=the_test_name if you know the test's name that you want to change. Search for const_eval_raw in .stderr files to find the test that your changes will touch

hosseind75 · 2020-09-19T15:42:56Z

sorry anyone knows that why the test of gnu-llvm-8 fails?

oli-obk · 2020-09-19T15:47:24Z

src/test/ui/proc-macro/invalid-punct-ident-1.stderr

@@ -1,3 +1,5 @@
+query stack during panic:


Please filter this out with more filter instructions in the corresponding .rs file, the same with all the other proc macros.

sorry I did not understand that what should I do
can you please explain more?

Did it not disappear after switching the condition?

In case it's still there after the change, what I meant was to add more of the regexes like

rust/src/test/ui/proc-macro/invalid-punct-ident-1.rs

Lines 5 to 11 in 767e84a

// normalize-stderr-test "thread.*panicked.*proc_macro_server.rs.*\n" -> ""

// normalize-stderr-test "note:.*RUST_BACKTRACE=1.*\n" -> ""

// normalize-stderr-test "\nerror: internal compiler error.*\n\n" -> ""

// normalize-stderr-test "note:.*unexpectedly panicked.*\n\n" -> ""

// normalize-stderr-test "note: we would appreciate a bug report.*\n\n" -> ""

// normalize-stderr-test "note: compiler flags.*\n\n" -> ""

// normalize-stderr-test "note: rustc.*running on.*\n\n" -> ""

in order to filter out these two new lines.
Basically I think you can add

// normalize-stderr-test "query stack during panic:\n" -> "" // normalize-stderr-test "end of query stack:\n" -> ""

and these lines should disappear

ok got it, thanks, I will fix now

src/test/ui/pattern/const-pat-ice.stderr

src/test/ui/consts/const-eval/const-eval-query-stack.stderr

compiler/rustc_driver/src/lib.rs

jyn514 · 2020-09-19T18:05:22Z

@hosseind75 it prints what the failures were:

failures:

---- [ui] ui/proc-macro/invalid-punct-ident-2.rs stdout ----
diff of stderr:

-	query stack during panic:
-	we're just showing a limited slice of the query stack
-	end of query stack
4	error: proc macro panicked
5	  --> $DIR/invalid-punct-ident-2.rs:16:1
6	   |


The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/proc-macro/invalid-punct-ident-2/invalid-punct-ident-2.stderr
 ---- [ui] ui/proc-macro/invalid-punct-ident-3.rs stdout ----
diff of stderr:

-	query stack during panic:
-	we're just showing a limited slice of the query stack
-	end of query stack
4	error: proc macro panicked
5	  --> $DIR/invalid-punct-ident-3.rs:16:1
6	   |


The actual stderr differed from the expected stderr.
 ---- [ui] ui/proc-macro/load-panic-backtrace.rs stdout ----
diff of stderr:

1	at 'panic-derive', $DIR/auxiliary/test-macros.rs:43:5
+	query stack during panic:
+	we're just showing a limited slice of the query stack
+	end of query stack
2	error: proc-macro derive panicked
3	  --> $DIR/load-panic-backtrace.rs:17:10
4	   |

hosseind75 · 2020-09-19T18:06:59Z

@hosseind75 it prints what the failures were:

failures:

---- [ui] ui/proc-macro/invalid-punct-ident-2.rs stdout ----
diff of stderr:

-	query stack during panic:
-	we're just showing a limited slice of the query stack
-	end of query stack
4	error: proc macro panicked
5	  --> $DIR/invalid-punct-ident-2.rs:16:1
6	   |


The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/proc-macro/invalid-punct-ident-2/invalid-punct-ident-2.stderr
 ---- [ui] ui/proc-macro/invalid-punct-ident-3.rs stdout ----
diff of stderr:

-	query stack during panic:
-	we're just showing a limited slice of the query stack
-	end of query stack
4	error: proc macro panicked
5	  --> $DIR/invalid-punct-ident-3.rs:16:1
6	   |


The actual stderr differed from the expected stderr.
 ---- [ui] ui/proc-macro/load-panic-backtrace.rs stdout ----
diff of stderr:

1	at 'panic-derive', $DIR/auxiliary/test-macros.rs:43:5
+	query stack during panic:
+	we're just showing a limited slice of the query stack
+	end of query stack
2	error: proc-macro derive panicked
3	  --> $DIR/load-panic-backtrace.rs:17:10
4	   |

yeah, I got that what It means now, thanks

hosseind75 · 2020-09-19T18:10:22Z

@jyn514 about load-panic-backtrace test, should I add those three lines by comments like other tests?

hosseind75 · 2020-09-20T12:19:31Z

guys maybe the problem is because of this issue #59998 right?
I mean about load-panic-backtrace test, I can fix two other failed tests, but about this I see FIXME comment in this file
do you think that it is related to that issue?
@oli-obk @jyn514

oli-obk · 2020-09-20T12:23:20Z

You can also patch https://github.com/rust-lang/rust/blob/master/src/test/ui/proc-macro/load-panic-backtrace.rs to filter out the new messages. Is it not showing up when you run locally?

hosseind75 · 2020-09-20T12:25:18Z

no, I ran this test locally but the ICEs messages did not show up In load-panic-backtrace.stderr

oli-obk · 2020-09-20T12:27:52Z

Is the test run at all, or do you get a "skipped" message? Maybe it's skipped on your platform?

hosseind75 · 2020-09-20T12:29:12Z

aah yeah, I ran it now and it is ignoring

jyn514 · 2020-09-26T00:13:37Z

I think you can test this with x.py test src/tools/clippy.

bors · 2020-09-26T09:07:48Z

☔ The latest upstream changes (presumably #70743) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

update master

hosseind75 · 2020-09-28T18:56:57Z

@jyn514 the test failure messages is like the messages that I got when I had automatic x.py check running
is it because of removing that?
I guess I screwed up a little about merging master into this branch right?😞

oli-obk · 2020-09-29T07:44:47Z

@hosseind75 try git rebase -i upstream/master (where upstream is your remote name for github.com/rust-lang/rust) and remove all commits that are not yours. You can also use this to squash all of your commits into a single commit.

jyn514 · 2020-09-29T12:56:46Z

See also rust-lang/rustc-dev-guide#890 which is pretty detailed.

…ack message when RUST_BACKTRACE=0

bjorn3 · 2020-09-29T14:47:16Z

compiler/rustc_middle/src/ty/query/plumbing.rs

+>>>>>>> 15827338aa231fd408561bf5db8d8eea85d1a51a
+=======
+                    if num_frames == Some(i) {
+>>>>>>> 15827338aa231fd408561bf5db8d8eea85d1a51a


This is a messed up rebase.

jyn514 · 2020-09-29T21:32:22Z

src/test/ui/pattern/const-pat-ice.stderr

 #0 [check_match] match-checking `main`
 #1 [analysis] running analysis passes on this crate
-we're just showing a limited slice of the query stack
+we're just showing a limited slice of the query stack


I think this will cause bors to fail again, is there a reason you removed it?

you mean about new line? @jyn514

Yeah, you removed the newline.

hosseind88 · 2020-10-03T15:55:13Z

guys a problem happened for my acount and I forced to create new acount, sorry, I opened a new PR for this issue , it is the link #77493

…_the_top_of_the_query_stack, r=oli-obk ICEs should always print the top of the query stack see rust-lang#76920

ICEs should print the top of the query stack

5fd6301

rust-highfive assigned oli-obk Sep 19, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 19, 2020

jyn514 added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 19, 2020

run full query stack print just when RUST_BACKTRACE is set

132c9ef

oli-obk reviewed Sep 19, 2020

View reviewed changes

compiler/rustc_driver/src/lib.rs Outdated Show resolved Hide resolved

change approach and run ui tests

767e84a

oli-obk reviewed Sep 19, 2020

View reviewed changes

src/test/ui/pattern/const-pat-ice.stderr Show resolved Hide resolved

oli-obk reviewed Sep 19, 2020

View reviewed changes

src/test/ui/consts/const-eval/const-eval-query-stack.stderr Outdated Show resolved Hide resolved

oli-obk reviewed Sep 19, 2020

View reviewed changes

compiler/rustc_driver/src/lib.rs Outdated Show resolved Hide resolved

hosseind75 added 2 commits September 19, 2020 21:29

show a message when we are showing limited slice of query stack

339181a

fix invalid-punct-ident-1 test

51c32f4

hosseind75 and others added 3 commits September 28, 2020 22:07

add new line

3621afe

Merge pull request #1 from rust-lang/master

4e88307

update master

merge master into

58cf7c4

hosseind75 added 11 commits September 29, 2020 17:22

update master

8528f40

update branch with master

1582733

ICEs should print the top of the query stack

8983d5b

run full query stack print just when RUST_BACKTRACE is set

a1ef12b

fix invalid-punct-ident-1 test

3be44f9

add filter regexes to load-panic-backtraces test

56d6be3

fix show we're just showing... message instead of the end of query st…

e837539

…ack message when RUST_BACKTRACE=0

fix clippy custom_ice_message test

51d2e7e

add new line

8bfeaef

rebase with master

d61d859

rebase with master

f4b7a5e

bjorn3 reviewed Sep 29, 2020

View reviewed changes

hosseind75 added 2 commits September 29, 2020 18:56

fix rebase messed up files

bf73a64

remove new line

665bd46

jyn514 reviewed Sep 29, 2020

View reviewed changes

hosseind88 mentioned this pull request Oct 3, 2020

ICEs should always print the top of the query stack #77493

Merged

oli-obk closed this Oct 5, 2020

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 15, 2020

Rollup merge of rust-lang#77493 - hosseind88:ICEs_should_always_print…

122f5c1

…_the_top_of_the_query_stack, r=oli-obk ICEs should always print the top of the query stack see rust-lang#76920

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 15, 2020

Rollup merge of rust-lang#77493 - hosseind88:ICEs_should_always_print…

e16dee1

…_the_top_of_the_query_stack, r=oli-obk ICEs should always print the top of the query stack see rust-lang#76920

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 16, 2020

Rollup merge of rust-lang#77493 - hosseind88:ICEs_should_always_print…

0e4d196

…_the_top_of_the_query_stack, r=oli-obk ICEs should always print the top of the query stack see rust-lang#76920

bors pushed a commit to rust-lang-ci/rust that referenced this pull request Oct 24, 2020

Rollup merge of rust-lang#77493 - hosseind88:ICEs_should_always_print…

d2feccc

…_the_top_of_the_query_stack, r=oli-obk ICEs should always print the top of the query stack see rust-lang#76920

	// normalize-stderr-test "thread.panicked.proc_macro_server.rs.*\n" -> ""
	// normalize-stderr-test "note:.RUST_BACKTRACE=1.\n" -> ""
	// normalize-stderr-test "\nerror: internal compiler error.*\n\n" -> ""
	// normalize-stderr-test "note:.unexpectedly panicked.\n\n" -> ""
	// normalize-stderr-test "note: we would appreciate a bug report.*\n\n" -> ""
	// normalize-stderr-test "note: compiler flags.*\n\n" -> ""
	// normalize-stderr-test "note: rustc.running on.\n\n" -> ""

Uh oh!

Conversation

hosseind75 commented Sep 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Sep 19, 2020

Uh oh!

oli-obk commented Sep 19, 2020

Uh oh!

hosseind75 commented Sep 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jyn514 commented Sep 19, 2020

Uh oh!

jyn514 commented Sep 19, 2020

Uh oh!

hosseind75 commented Sep 19, 2020

Uh oh!

Uh oh!

oli-obk commented Sep 19, 2020

Uh oh!

hosseind75 commented Sep 19, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jyn514 commented Sep 19, 2020

Uh oh!

hosseind75 commented Sep 19, 2020

Uh oh!

hosseind75 commented Sep 19, 2020

Uh oh!

hosseind75 commented Sep 20, 2020

Uh oh!

oli-obk commented Sep 20, 2020

Uh oh!

hosseind75 commented Sep 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oli-obk commented Sep 20, 2020

Uh oh!

hosseind75 commented Sep 20, 2020

Uh oh!

jyn514 commented Sep 26, 2020

Uh oh!

bors commented Sep 26, 2020

Uh oh!

hosseind75 commented Sep 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oli-obk commented Sep 29, 2020

Uh oh!

jyn514 commented Sep 29, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hosseind75 Oct 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hosseind88 commented Oct 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

hosseind75 commented Sep 19, 2020 •

edited

Loading

hosseind75 commented Sep 19, 2020 •

edited

Loading

hosseind75 commented Sep 20, 2020 •

edited

Loading

hosseind75 commented Sep 28, 2020 •

edited

Loading

hosseind75 Oct 3, 2020 •

edited

Loading