Changing the alloc() to accept &self instead of &mut self#76993
Merged
bors merged 7 commits intorust-lang:masterfrom Sep 24, 2020
blitzerr:alloc-ref
Merged
Changing the alloc() to accept &self instead of &mut self#76993bors merged 7 commits intorust-lang:masterfrom blitzerr:alloc-ref
bors merged 7 commits intorust-lang:masterfrom
blitzerr:alloc-ref
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
r? @Amanieu cc @TimDiekmann |
blitzerr
changed the title
TimDiekmann
reviewed
Sep 21, 2020
Member
|
Could you rebase onto master and force push so we don't have the changes from all the other commits? |
Member
|
Can you also change the other methods of |
Contributor
Author
Ohh ! I am so sorry for all the junk. I thought I did force push but apparently not :) Now it is done |
Contributor
Author
@Amanieu I will certainly do that. :) This is my first PR into stdlib. So I wanted all builds to pass cleanly with just the |
TimDiekmann
reviewed
Sep 22, 2020
Amanieu
reviewed
Sep 22, 2020
Contributor
Author
|
Awesome ! Thanks for being proactive with the PR. I will incorporate all the suggestions. |
blitzerr
changed the title
Member
|
@bors r+ |
Collaborator
|
📌 Commit 2b19b14 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 23, 2020
Rollup of 9 pull requests Successful merges: - rust-lang#76898 (Record `tcx.def_span` instead of `item.span` in crate metadata) - rust-lang#76939 (emit errors during AbstractConst building) - rust-lang#76965 (Add cfg(target_has_atomic_equal_alignment) and use it for Atomic::from_mut.) - rust-lang#76993 (Changing the alloc() to accept &self instead of &mut self) - rust-lang#76994 (fix small typo in docs and comments) - rust-lang#77017 (Add missing examples on Vec iter types) - rust-lang#77042 (Improve documentation for ToSocketAddrs) - rust-lang#77047 (Miri: more informative deallocation error messages) - rust-lang#77055 (Add #[track_caller] to more panicking Cell functions) Failed merges: r? `@ghost`
al3xtjames
added a commit
to al3xtjames/r-efi-alloc
that referenced
this pull request
Oct 1, 2020
Needed since rust-lang/rust#76993 Signed-off-by: Alex James <[email protected]>
dvdhrm
pushed a commit
to r-efi/r-efi-alloc
that referenced
this pull request
Oct 1, 2020
Needed since rust-lang/rust#76993 Signed-off-by: Alex James <[email protected]>
parasyte
pushed a commit
to parasyte/allocator-suite
that referenced
this pull request
Oct 21, 2020
- Incorporates changes for: - rust-lang/rust#76993 - rust-lang/rust#77315
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #55
This is the first cut. It only makes the change for
allocmethod.