Force posix-style quoting on lld, independent of host platform#77543
Force posix-style quoting on lld, independent of host platform#77543bors merged 1 commit intorust-lang:masterfrom
Conversation
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Mark-Simulacrum
force-pushed
the
rsp-quoting
branch
3 times, most recently
from
9b62c0b to
ec7a77a
Compare
|
@bors try |
|
⌛ Trying commit ec7a77a4631bb005d78b755a9584cbdbf2c756d6 with merge c4ca2fa230dcaef515acf148ec70c1850bbe5dc1... |
|
☀️ Try build successful - checks-actions, checks-azure |
|
It looks like we have a confirmation that this is a fix for the LLD bug, so I am unilaterally beta accepting - this fixes a critical regression, and seems like a straightforward and reasonable patch. |
Mark-Simulacrum
added
beta-accepted
An upstream LLVM change changed behavior here to respect the host system quoting rules; previously the posix-style format was always used for @files.
Mark-Simulacrum
force-pushed
the
rsp-quoting
branch
from
ec7a77a to
e8325b0
Compare
|
@bors r+ |
|
📌 Commit e8325b0 has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=1 |
|
☀️ Test successful - checks-actions, checks-azure |
…albini [stable] 1.47 release This PR includes backports of: * Fix miscompile in SimplifyBranchSame rust-lang#77549 * Force posix-style quoting on lld, independent of host platform rust-lang#77543 Note that both are still beta-nominated/beta-accepted, as they need to be backported to 1.48 as well (future beta branch).
Mark-Simulacrum
removed
the
beta-nominated
…ulacrum [beta] backports This backports the following: * Improve build-manifest to work with the improved promote-release rust-lang#77407 * Force posix-style quoting on lld, independent of host platform rust-lang#77543 * Fix miscompile in SimplifyBranchSame rust-lang#77549 * Update RLS and Rustfmt rust-lang#77590 * Move `EarlyOtherwiseBranch` to mir-opt-level 2 rust-lang#77582
|
@Mark-Simulacrum is there a reason this was only for |
|
@eddyb indicated it would break things if it wasn't (https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/last.20minute.20beta.20backport/near/212289115); I did not follow up beyond that. Given the insta-stable backport I was hesitant to be too general, especially as I personally cannot test on windows at all. |
|
Mentioned llvm/llvm-project@928e9e1 did change only ELF backed. So there must have been another change for COFF that was missed. |
|
I'd really appreciate if this can be fixed :) (Currently it's preventing me from building my VST plugin for 32-bit with lld.) |
|
I highly recommend filing an issue if this is still a problem. I suspect digging through lld commit history to figure out if perhaps the quoting default changed on other platforms as well would be worthwhile to try and track down the problem. |
|
@Mark-Simulacrum Do you mean filing an issue on this repo? Or where? |
|
Yes, on this repository, ideally with steps for reproduction. |
8 participants
This just blindly applies the logic from @eddyb's comment here: #76466 (comment)
Hopefully, this fixed #76466 -- I cannot test this though.