min_const_generics diagnostics improvements#77825
Merged
bors merged 5 commits intorust-lang:masterfrom Oct 14, 2020
Merged
Conversation
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jyn514
added
A-diagnostics
Member
|
r? @lcnr |
Contributor
|
Nice, good job 👍 @bors r+ rollup |
Collaborator
|
📌 Commit d7029cb has been approved by |
bors
added
S-waiting-on-bors
Contributor
|
Having taken a look at the errors in practice, I think there are a couple of minor tweaks that could make them more readable, so I'm going to leave a bit more feedback. Sorry for the trouble. @bors r- |
bors
added
S-waiting-on-author
varkor
reviewed
Oct 12, 2020
Contributor
varkor
left a comment
varkor
left a comment
There was a problem hiding this comment.
Maybe we can discuss this further on Zulip if any of my suggestions are contentious.
Co-authored-by: varkor <[email protected]>
varkor
reviewed
Oct 12, 2020
varkor
reviewed
Oct 12, 2020
Co-authored-by: varkor <[email protected]>
Co-authored-by: varkor <[email protected]>
Contributor
|
I'm happy with the diagnostics now, so if @lcnr is also happy, we're good to go :) |
Contributor
|
lgtm @bors r+ |
Collaborator
|
📌 Commit 79351b1 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 13, 2020
…stic, r=lcnr `min_const_generics` diagnostics improvements As disscussed in [zulip/project-const-generics/non-trivial anonymous constant](https://rust-lang.zulipchat.com/#narrow/stream/260443-project-const-generics/topic/non-trivial.20anonymous.20constants). This is my first PR on the compiler. @lcnr is mentoring me on this PR. Related to rust-lang#60551.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 13, 2020
…stic, r=lcnr `min_const_generics` diagnostics improvements As disscussed in [zulip/project-const-generics/non-trivial anonymous constant](https://rust-lang.zulipchat.com/#narrow/stream/260443-project-const-generics/topic/non-trivial.20anonymous.20constants). This is my first PR on the compiler. @lcnr is mentoring me on this PR. Related to rust-lang#60551.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 13, 2020
Rollup of 14 pull requests Successful merges: - rust-lang#77239 (Enable building Cargo for aarch64-apple-darwin) - rust-lang#77569 (BTreeMap: type-specific variants of node_as_mut and cast_unchecked) - rust-lang#77719 (Remove unnecessary rustc_const_stable attributes.) - rust-lang#77722 (Remove unsafety from sys/unsupported and add deny(unsafe_op_in_unsafe_fn).) - rust-lang#77725 (Add regression issue template) - rust-lang#77776 ( Give an error when running `x.py test --stage 0 src/test/ui`) - rust-lang#77786 (Mention rustdoc in `x.py setup`) - rust-lang#77825 (`min_const_generics` diagnostics improvements) - rust-lang#77868 (Include `llvm-dis`, `llc` and `opt` in `llvm-tools-preview` component) - rust-lang#77884 (Use Option::unwrap_or instead of open-coding it) - rust-lang#77886 (Replace trivial bool matches with the `matches!` macro) - rust-lang#77892 (Replace absolute paths with relative ones) - rust-lang#77895 (Include aarch64-apple-darwin in the dist manifests) - rust-lang#77909 (bootstrap: set correct path for the build-manifest binary) Failed merges: - rust-lang#77902 (Include aarch64-pc-windows-msvc in the dist manifests) r? `@ghost`
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As disscussed in zulip/project-const-generics/non-trivial anonymous constant.
This is my first PR on the compiler.
@lcnr is mentoring me on this PR.
Related to #60551.