Use intra-doc links for links to module-level docs#77870

camelid · 2020-10-12T20:46:36Z

r? @jyn514

camelid · 2020-10-12T20:47:07Z

Note that I haven't yet checked in my browser to make sure the links are correct.

library/core/src/cell.rs

library/core/src/result.rs

library/std/src/path.rs

library/core/src/iter/sources.rs

library/alloc/src/alloc.rs

jyn514 · 2020-10-12T21:57:06Z

r=me with CI passing

camelid · 2020-10-13T00:44:18Z

I had to revert the changes to btree/{map.rs, set.rs} since the documentation linked to is in std, not alloc. Maybe it should be moved? Probably in a different PR though.

jyn514 · 2020-10-13T01:08:30Z

I had to revert the changes to btree/{map.rs, set.rs} since the documentation linked to is in std, not alloc. Maybe it should be moved?

It can't be moved because it links to HashMap which is only in std: 4065846

jyn514 · 2020-10-13T18:13:18Z

@bors r+

bors · 2020-10-13T18:13:19Z

📌 Commit 95221b4 has been approved by jyn514

Rollup of 8 pull requests Successful merges: - rust-lang#77765 (Add LLVM flags to limit DWARF version to 2 on BSD) - rust-lang#77788 (BTreeMap: fix gdb provider on BTreeMap with ZST keys or values) - rust-lang#77795 (Codegen backend interface refactor) - rust-lang#77808 (Moved the main `impl` for FnCtxt to its own file.) - rust-lang#77817 (Switch rustdoc from `clean::Stability` to `rustc_attr::Stability`) - rust-lang#77829 (bootstrap: only use compiler-builtins-c if they exist) - rust-lang#77870 (Use intra-doc links for links to module-level docs) - rust-lang#77897 (Move `Strip` into a separate rustdoc pass) Failed merges: - rust-lang#77879 (Provide better documentation and help messages for x.py setup) - rust-lang#77902 (Include aarch64-pc-windows-msvc in the dist manifests) r? `@ghost`

rust-highfive assigned jyn514 Oct 12, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2020

camelid force-pushed the intra-doc-super branch from 0a9a5dc to 3cba263 Compare October 12, 2020 21:33

camelid changed the title ~~Use intra-doc links for super~~ Use intra-doc links for links to module-level docs Oct 12, 2020

jyn514 reviewed Oct 12, 2020

View reviewed changes

camelid force-pushed the intra-doc-super branch from 3cba263 to 4ffb0ff Compare October 12, 2020 21:47

jyn514 reviewed Oct 12, 2020

View reviewed changes

library/alloc/src/alloc.rs Outdated Show resolved Hide resolved

camelid force-pushed the intra-doc-super branch from ecaa227 to 8036af2 Compare October 13, 2020 00:41

Use intra-doc links for links to module-level docs

95221b4

camelid force-pushed the intra-doc-super branch from 8036af2 to 95221b4 Compare October 13, 2020 02:23

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2020

Dylan-DPC-zz mentioned this pull request Oct 14, 2020

Rollup of 8 pull requests #77926

Merged

bors merged commit ed34f82 into rust-lang:master Oct 14, 2020

rustbot added this to the 1.49.0 milestone Oct 14, 2020

camelid deleted the intra-doc-super branch October 14, 2020 05:29

WaffleLapkin mentioned this pull request Oct 14, 2020

Split each iterator adapter and source into individual modules #77697

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use intra-doc links for links to module-level docs#77870