Merged
Conversation
camelid
added
the
A-testsuite
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
|
Also, #75763 says it shouldn't compile, so maybe the issue shouldn't be closed even though the ICE is fixed? |
jyn514
added
the
T-compiler
Member
|
I think closing #75673 is likely fine -- the broader issue of whether invalid UTF-8 in const generic &str should be caught during transmutes is something to settle before stabilization of str in consts. (It is unclear to me that we indeed must prohibit such a thing, as indicated on said issue). cc @lcnr just in case though @bors r+ |
Collaborator
|
📌 Commit 25dbbbd4a060bd8fce07f8a6ed03d30c82266ff3 has been approved by |
bors
added
S-waiting-on-bors
Member
|
Oh, looks like CI is failing here:
@bors r- (r=me with that fixed though) |
bors
added
S-waiting-on-author
lcnr
reviewed
Oct 26, 2020
camelid
force-pushed
the
regression-tests
branch
from
25dbbbd to
94ed945
Compare
Co-authored-by: lcnr <[email protected]>
camelid
added
S-waiting-on-review
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 4641d2e has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 27, 2020
Rollup of 16 pull requests Successful merges: - rust-lang#76635 (Add [T]::as_chunks(_mut)) - rust-lang#77703 (add system-llvm-libunwind config option) - rust-lang#78219 (Prefer to use `print_def_path`) - rust-lang#78298 (Add test for bad NLL higher-ranked subtype) - rust-lang#78332 (Update description for error E0308) - rust-lang#78342 (Use check-pass in single-use-lifetime ui tests) - rust-lang#78347 (Add lexicographical comparison doc) - rust-lang#78348 (Make some functions private that don't have to be public) - rust-lang#78349 (Use its own `TypeckResults` to avoid ICE) - rust-lang#78375 (Use ? in core/std macros) - rust-lang#78377 (Fix typo in debug statement) - rust-lang#78388 (Add some regression tests) - rust-lang#78394 (fix(docs): typo in BufWriter documentation) - rust-lang#78396 (Add compiler support for LLVM's x86_64 ERMSB feature) - rust-lang#78405 (Fix typo in lint description) - rust-lang#78412 (Improve formatting of hash collections docs) Failed merges: r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75763.
Closes #76179.