resolve: private fields in tuple struct ctor diag#78401
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 28, 2020
Merged
resolve: private fields in tuple struct ctor diag#78401bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
This commit improves the diagnostic emitted when a tuple struct is being constructed which has private fields so that private fields are labelled and the message is improved. Signed-off-by: David Wood <david@davidtw.co>
rust-highfive
added
the
S-waiting-on-review
estebank
reviewed
Oct 26, 2020
Comment on lines
+972
to
+974
| non_visible_spans | ||
| .into_iter() | ||
| .for_each(|s| m.push_span_label(s, "private field".to_string())); |
Contributor
There was a problem hiding this comment.
oh! I hadn't thought about doing this this way! neat.
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 27bb27f has been approved by |
bors
added
S-waiting-on-bors
guswynn
reviewed
Oct 28, 2020
Contributor
guswynn
left a comment
guswynn
left a comment
There was a problem hiding this comment.
I believe for both constructor and pattern cases we need to still extend this to work across crate boundaries (see src/test/ui/issues/issue-75907_b.rs not having the private_field spans)
should we create a follow up issue?
Member
Author
I think that would make sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75906.
This PR improves the diagnostic emitted when a tuple struct is being constructed which has private fields so that private fields are labelled and the message is improved.
r? @estebank