improve type const mismatch errors#79032
Merged
bors merged 3 commits intorust-lang:masterfrom Nov 17, 2020
Merged
Conversation
lcnr
added
F-const_generics
rust-highfive
added
the
S-waiting-on-review
JulianKnodt
reviewed
Nov 13, 2020
varkor
reviewed
Nov 16, 2020
Contributor
varkor
left a comment
varkor
left a comment
There was a problem hiding this comment.
Implementation looks good to me, and the diagnostics improvements are really nice, thanks! I just have one suggestion about a diagnostic tweak.
Contributor
|
r=me after squashing. |
Contributor
Author
|
@bors r=varkor rollup |
Collaborator
|
📌 Commit 69b43c2 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 16, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#74989 (Implement `Index` and `IndexMut` for arrays) - rust-lang#76339 (Test structural matching for all range types) - rust-lang#77691 (Rename/Deprecate LayoutErr in favor of LayoutError) - rust-lang#78364 (Update RELEASES.md for 1.48.0) - rust-lang#78678 (Add tests and improve rendering of cfgs on traits) - rust-lang#78714 (Simplify output capturing) - rust-lang#78769 (Remove unneeded lifetimes in array/mod.rs) - rust-lang#78903 (BTreeMap: test chaotic ordering & other bits & bobs) - rust-lang#79032 (improve type const mismatch errors) - rust-lang#79061 (Make all rustdoc functions and structs crate-private) - rust-lang#79087 (Update E0744 about control flow in `const` contexts to accurately describe when the error is triggered and why) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't completely remove
check_generic_arg_countas that would have required some more complex changes butinstead checks type and const params in only one step. Also moved the help added by @JulianKnodt in #75611 to
generic_arg_mismatch_err.r? @varkor cc @petrochenkov