build-manifest: strip newline from rustc version#79096
Merged
bors merged 1 commit intorust-lang:stablefrom Nov 16, 2020
Merged
Conversation
Contributor
|
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors r+ rollup=never p=100 |
Collaborator
|
📌 Commit 82a102b has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Nov 17, 2020
…, r=Mark-Simulacrum build-manifest: strip newline from rustc version Backport of rust-lang#79096 on the master branch. This will also need to be included in the beta bump tomorrow. r? `@Mark-Simulacrum` `@rustbot` modify labels: beta-nominated beta-accepted T-infra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running the release process for Rust 1.48.0 I discovered a bug in
build-manifest: it's not trimming the newline fromsrc/version, and it tries to inspect tarballs calledrustc-1.48.0\n-x86_64-unknown-linux-gnu.tar.xz. The bug only affects stable releases so this is why we're only seeing it right now.r? @Mark-Simulacrum
We'll need to backport this to beta and nightly too.