Make the kernel_copy tests more robust/concurrent.#79375
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 11, 2020
Merged
Make the kernel_copy tests more robust/concurrent.#79375bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
There's a typo in the commit message: |
Member
|
LGTM |
Contributor
Author
|
Can I force push to fix the typo? |
Member
|
There's no policy against that. CI will check your commits again anway. |
vext01
force-pushed
the
kernel-copy-temps
branch
from
562e91b to
562474a
Compare
Contributor
Author
|
Fixed. |
Contributor
Author
|
I guess @joshtriplett is busy. Is someone else able to start the merge? @the8472? |
Member
|
I don't have the necessary permissions to do that. You'll have to wait. IME PRs may take a few weeks, depending on how busy team members are. |
Contributor
Author
|
Is anyone able to kick the merge off for this? @joshtriplett ? Sorry to be so persistent, but this bug is frequently biting us in our CI pipeline :( |
Member
|
In the meantime you might want to update the PR to also apply the tempdir changes to the test added by #79600 |
These tests write to the same filenames in /tmp and in some cases these
files don't get cleaned up properly. This caused issues for us when
different users run the tests on the same system, e.g.:
```
---- sys::unix::kernel_copy::tests::bench_file_to_file_copy stdout ----
thread 'sys::unix::kernel_copy::tests::bench_file_to_file_copy' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }', library/std/src/sys/unix/kernel_copy/tests.rs:71:10
---- sys::unix::kernel_copy::tests::bench_file_to_socket_copy stdout ----
thread 'sys::unix::kernel_copy::tests::bench_file_to_socket_copy' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }', library/std/src/sys/unix/kernel_copy/tests.rs:100:10
```
Use `std::sys_common::io__test::tmpdir()` to solve this.
vext01
force-pushed
the
kernel-copy-temps
branch
from
562474a to
87c1fdb
Compare
Contributor
Author
|
done! |
Member
|
@bors r+ rollup I didn't previously approve it as I wasn't sure if this PR was in scope of the r+ rights I recently got, but I just got a confirmation that it is fine. |
Collaborator
|
📌 Commit 87c1fdb has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 10, 2020
Make the kernel_copy tests more robust/concurrent.
These tests write to the same filenames in /tmp and in some cases these files don't get cleaned up properly. This caused issues for us when different users run the tests on the same system, e.g.:
```
---- sys::unix::kernel_copy::tests::bench_file_to_file_copy stdout ----
thread 'sys::unix::kernel_copy::tests::bench_file_to_file_copy' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }', library/std/src/sys/unix/kernel_copy/tests.rs:71:10
---- sys::unix::kernel_copy::tests::bench_file_to_socket_copy stdout ----
thread 'sys::unix::kernel_copy::tests::bench_file_to_socket_copy' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }', library/std/src/sys/unix/kernel_copy/tests.rs💯10
```
Use `std::sys_common::io__test::tmpdir()` to solve this.
CC `@the8472.`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 11, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#77027 (Improve documentation for `std::{f32,f64}::mul_add`) - rust-lang#79375 (Make the kernel_copy tests more robust/concurrent.) - rust-lang#79639 (Add long explanation for E0212) - rust-lang#79698 (Add tracking issue template for library features.) - rust-lang#79809 (Dogfood `str_split_once()`) - rust-lang#79851 (Clarify the 'default is only allowed on...' error) - rust-lang#79858 (Update const-fn doc in unstable-book) - rust-lang#79860 (Clarify that String::split_at takes a byte index.) - rust-lang#79871 (Fix small typo in `wrapping_shl` documentation) - rust-lang#79896 (Make search results tab and help button focusable with keyboard) - rust-lang#79917 (Use Symbol for inline asm register class names) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
vext01
added a commit
to vext01/ykrustc
that referenced
this pull request
Dec 11, 2020
…20201211 So as to inherit: rust-lang/rust#79375
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests write to the same filenames in /tmp and in some cases these files don't get cleaned up properly. This caused issues for us when different users run the tests on the same system, e.g.:
Use
std::sys_common::io__test::tmpdir()to solve this.CC @the8472.