Skip to content

Use detailed and shorter fs error explaination#79399

Merged
bors merged 1 commit intorust-lang:masterfrom
pickfire:patch-3
Mar 27, 2021
Merged

Use detailed and shorter fs error explaination#79399
bors merged 1 commit intorust-lang:masterfrom
pickfire:patch-3

Conversation

@pickfire
Copy link
Contributor

@pickfire pickfire commented Nov 25, 2020

Includes suggestion from @the8472 #79390 (comment)

@rust-highfive
Copy link
Contributor

rust-highfive commented Nov 25, 2020

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 25, 2020
@pickfire pickfire mentioned this pull request Nov 25, 2020
Open
@camelid camelid added A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Nov 25, 2020
jonas-schievink
jonas-schievink reviewed Nov 25, 2020
View reviewed changes
@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2020
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 1, 2021
@JohnCSimon
Copy link
Member

JohnCSimon commented Feb 1, 2021

triage:
@pickfire can you please post your status on this PR?

@pickfire
Copy link
Contributor Author

pickfire commented Feb 1, 2021

@JohnCSimon I am waiting for reviewers to give feedbacks and comments, I shared suggestions above but no one give feedback.

@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 22, 2021
@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2021
@pickfire
Copy link
Contributor Author

pickfire commented Mar 26, 2021

r=@JohnTitor

@pickfire
Copy link
Contributor Author

pickfire commented Mar 26, 2021

@bors r=@JohnTitor

@bors
Copy link
Collaborator

bors commented Mar 26, 2021

@pickfire: 🔑 Insufficient privileges: Not in reviewers

@pickfire pickfire mentioned this pull request Mar 26, 2021
Merged
@JohnTitor
Copy link
Member

JohnTitor commented Mar 27, 2021

Could you also squash commits into one?

@pickfire
Use detailed and shorter fs error explaination
5495ce0 
Includes suggestion from the8472 rust-lang#79390 (comment)

More detail error explanation in fs doc
@pickfire
Copy link
Contributor Author

pickfire commented Mar 27, 2021

Done

pickfire added a commit to pickfire/rust that referenced this pull request Mar 27, 2021
@pickfire
Improve fs error open_from unix
6c6ef73 
Consistency for rust-lang#79399
Suggested by JohnTitor

Improve fs error invaild input for sys_common

The text was duplicated from unix.
@JohnTitor
Copy link
Member

JohnTitor commented Mar 27, 2021

Thanks! @bors r+

@bors
Copy link
Collaborator

bors commented Mar 27, 2021

📌 Commit 5495ce0 has been approved by JohnTitor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2021
@bors
Copy link
Collaborator

bors commented Mar 27, 2021

⌛ Testing commit 5495ce0 with merge 99595f1842d4042789718c373f46b9eb5b534707...

@JohnTitor JohnTitor mentioned this pull request Mar 27, 2021
Merged
@JohnTitor
Copy link
Member

JohnTitor commented Mar 27, 2021

@bors retry yielding

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2021
@bors
Auto merge of rust-lang#83573 - JohnTitor:rollup-28jnzsr, r=JohnTitor
afaf33d 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#79399 (Use detailed and shorter fs error explaination)
 - rust-lang#83348 (format macro argument parsing fix)
 - rust-lang#83462 (ExitStatus: print "exit status: {}" rather than "exit code: {}" on unix)
 - rust-lang#83526 (lazily calls some fns)
 - rust-lang#83558 (Use DebugStruct::finish_non_exhaustive() in std.)
 - rust-lang#83559 (Fix Debug implementation for RwLock{Read,Write}Guard.)
 - rust-lang#83560 (Derive Debug for io::Chain instead of manually implementing it.)
 - rust-lang#83561 (Improve Debug implementations of Mutex and RwLock.)
 - rust-lang#83567 (Update rustup cross-compilation docs link)
 - rust-lang#83569 (Add regression tests for rust-lang#56445)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Mar 27, 2021

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors bors merged commit 1f33a6a into rust-lang:master Mar 27, 2021
@rustbot rustbot added this to the 1.53.0 milestone Mar 27, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 27, 2021
@Dylan-DPC
Rollup merge of rust-lang#83522 - pickfire:patch-6, r=JohnTitor
aee7b9e 
Improve fs error open_from unix

Consistency for rust-lang#79399
Suggested by JohnTitor

r? `@JohnTitor`

Not user if the error is too long now, do we handle long errors well?
@pickfire pickfire deleted the patch-3 branch March 29, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@the8472 the8472 the8472 left review comments

@JohnTitor JohnTitor JohnTitor approved these changes

+1 more reviewer

@jonas-schievink jonas-schievink jonas-schievink left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@joshtriplett joshtriplett

Labels

A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.53.0

Development

Successfully merging this pull request may close these issues.