Conversation
|
r? @lcnr (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
doc-keyword-lint-pass
branch
from
3ee9187 to
cd35f84
Compare
GuillaumeGomez
force-pushed
the
doc-keyword-lint-pass
branch
16 times, most recently
from
d34308b to
3b00fb0
Compare
|
@bors try |
|
⌛ Trying commit 3b00fb05050992a7a72fc97b1165c1cbb95de489 with merge 06bd5158a41e9e157607119713430936d68977f6... |
|
☀️ Try build successful - checks-actions |
GuillaumeGomez
force-pushed
the
doc-keyword-lint-pass
branch
from
3b00fb0 to
224c732
Compare
|
This is finally working! \o/ The trick was to run the check on the std lib with |
lcnr
left a comment
lcnr
left a comment
There was a problem hiding this comment.
can you add a test for this to src/test/ui-fulldeps?
Doing so should be similar to to https://github.com/rust-lang/rust/blob/master/src/test/ui-fulldeps/internal-lints/qualified_ty_ty_ctxt.rs
implementation lgtm
GuillaumeGomez
force-pushed
the
doc-keyword-lint-pass
branch
2 times, most recently
from
95fcdc5 to
df1e496
Compare
GuillaumeGomez
force-pushed
the
doc-keyword-lint-pass
branch
from
df1e496 to
50eb3a8
Compare
|
Seems like it's ready. Anything else remaining to be done @lcnr ? Thanks for your comments in any case! :) |
|
@bors delegate+ |
|
✌️ @GuillaumeGomez can now approve this pull request |
|
@bors: r=lcnr |
|
📌 Commit 50eb3a8 has been approved by |
bors
added
S-waiting-on-bors
…s, r=lcnr Doc keyword lint pass `x.py test` doesn't seem to work locally for multiple reasons so simpler to just run CI...
Rollup of 11 pull requests Successful merges: - rust-lang#77686 (Render Markdown in search results) - rust-lang#79541 (Doc keyword lint pass) - rust-lang#79602 (Fix SGX CI) - rust-lang#79611 (Use more std:: instead of core:: in docs for consistency) - rust-lang#79623 (Pass around Symbols instead of Idents in doctree) - rust-lang#79627 (Update cargo) - rust-lang#79631 (disable a ptr equality test on Miri) - rust-lang#79638 (Use `item_name` instead of pretty printing for resolving `Self` on intra-doc links) - rust-lang#79646 (rustc_metadata: Remove some dead code) - rust-lang#79664 (move interpret::MemoryKind::Heap to const eval) - rust-lang#79678 (Fix some clippy lints) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
5 participants
x.py testdoesn't seem to work locally for multiple reasons so simpler to just run CI...