Skip to content

Provide more information for HRTB lifetime errors involving closures#79588

Merged
bors merged 1 commit intorust-lang:masterfrom
estebank:issue-79187
Jan 13, 2021
Merged

Provide more information for HRTB lifetime errors involving closures#79588
bors merged 1 commit intorust-lang:masterfrom
estebank:issue-79187

Conversation

@estebank
Copy link
Contributor

@estebank estebank commented Dec 1, 2020

No description provided.

@rust-highfive
Copy link
Contributor

rust-highfive commented Dec 1, 2020

r? @ecstatic-morse

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 1, 2020
estebank
estebank commented Dec 1, 2020
View reviewed changes
src/test/ui/lifetimes/issue-79187-2.stderr Outdated
Comment on lines +14 to +18
Copy link
Contributor Author

@estebank estebank Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't considered this case in particular, but ideally we would (also) point at the where clause in impl<F> Foo for F where F: Fn(&i32) -> &i32 for this...

@estebank
Copy link
Contributor Author

estebank commented Dec 1, 2020 •
edited
Loading

This is a mitigation of a stable to stable regression (#75791, older similar issue #41078), but not a fix.

@oli-obk
Copy link
Contributor

oli-obk commented Dec 2, 2020

r? @oli-obk

oli-obk
oli-obk reviewed Dec 2, 2020
View reviewed changes
src/test/ui/lifetimes/issue-79187-2.nll.stderr Outdated
Comment on lines +5 to +8
Copy link
Contributor

@oli-obk oli-obk Dec 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we have the information available anywhere, but could emit a diagnostic of this quality for the the required lifetime does not necessarily outlive the anonymous lifetime #1 defined on the body, too? This occurs in src/test/ui/generator/resume-arg-late-bound.stderr

oli-obk
oli-obk reviewed Dec 2, 2020
View reviewed changes
oli-obk
oli-obk reviewed Dec 2, 2020
View reviewed changes
@oli-obk
Copy link
Contributor

oli-obk commented Dec 2, 2020

The test diffs lgtm, but some of these new tests you added highlight some seriously unhelpful errors. Most of them have an independently emitted helpful error, but not all

@estebank
Copy link
Contributor Author

estebank commented Dec 2, 2020

The test diffs lgtm, but some of these new tests you added highlight some seriously unhelpful errors. Most of them have an independently emitted helpful error, but not all

Indeed. This is gonna be a rabbit-hole to clean up.

@oli-obk
Copy link
Contributor

oli-obk commented Dec 3, 2020

r=me with CI passing (probably just the missing newline). Let's address further improvements in other PRs, it's not necessary to do more in this one

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2021
@estebank
Copy link
Contributor Author

estebank commented Jan 12, 2021

@bors r=oli-obk

@bors
Copy link
Collaborator

bors commented Jan 12, 2021

📌 Commit a8a9742 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 12, 2021
@estebank estebank mentioned this pull request Jan 12, 2021
Open
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jan 13, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 13, 2021
@bors
Auto merge of rust-lang#80960 - Dylan-DPC:rollup-89tri8x, r=Dylan-DPC
fc93e47 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#78901 (diagnostics: Note capturing closures can't be coerced to fns)
 - rust-lang#79588 (Provide more information for HRTB lifetime errors involving closures)
 - rust-lang#80232 (Remove redundant def_id lookups)
 - rust-lang#80662 (Added support for i386-unknown-linux-gnu and i486-unknown-linux-gnu)
 - rust-lang#80736 (use Once instead of Mutex to manage capture resolution)
 - rust-lang#80796 (Update to LLVM 11.0.1)
 - rust-lang#80859 (Fix --pretty=expanded with --remap-path-prefix)
 - rust-lang#80922 (Revert "Auto merge of rust-lang#76896 - spastorino:codegen-inline-fns2)
 - rust-lang#80924 (Fix rustdoc --test-builder argument parsing)
 - rust-lang#80935 (Rename `rustc_middle::lint::LevelSource` to `LevelAndSource`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 11bca6b into rust-lang:master Jan 13, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 13, 2021
@estebank estebank deleted the issue-79187 branch November 9, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.51.0

Development

Successfully merging this pull request may close these issues.

7 participants

@estebank @rust-highfive @oli-obk @bors @JohnCSimon @ecstatic-morse @rustbot