Make BoundRegion have a kind of BoungRegionKind#80163
Conversation
1d063df to
2499ee6
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
lcnr
left a comment
There was a problem hiding this comment.
the change to replace_escaping_bound_vars lgtm
While I am not opposed to changing BoundRegion I also don't yet understand why this is needed.
Afaik the goal of #76814 is to replace BoundRegion with "just" an index into the relevant binder and it's not immediately obvious to me why this is a sensible step towards that goal
|
The problem is that in that PR, I'm only going so far as making The "final result" of #76814 will be bound regions tracking their bound vars in |
|
👍 in this case this does seem like an uncontroversial change to me @bors r+ |
|
📌 Commit 2499ee6e1674d4630b2061e6d820cbcda5533ca2 has been approved by |
2499ee6 to
328fcee
Compare
|
Had to bless tests for verbose output @lcnr So this will need a new r+ |
|
@bors r+ |
|
📌 Commit 328fcee has been approved by |
…lcnr Make BoundRegion have a kind of BoungRegionKind Split from rust-lang#76814 Also includes making `replace_escaping_bound_vars` only return `T` Going to r? `@lcnr` Feel free to reassign
…lcnr Make BoundRegion have a kind of BoungRegionKind Split from rust-lang#76814 Also includes making `replace_escaping_bound_vars` only return `T` Going to r? ``@lcnr`` Feel free to reassign
…lcnr Make BoundRegion have a kind of BoungRegionKind Split from rust-lang#76814 Also includes making `replace_escaping_bound_vars` only return `T` Going to r? ```@lcnr``` Feel free to reassign
|
☀️ Test successful - checks-actions |
Split from #76814
Also includes making
replace_escaping_bound_varsonly returnTGoing to r? @lcnr
Feel free to reassign